Bug 278599 - audio/amsynth: Fix build issue/Upgrade to version 1.13.3
Summary: audio/amsynth: Fix build issue/Upgrade to version 1.13.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/amsynth/amsynth/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-26 21:09 UTC by Patrick TJ McPhee
Modified: 2024-04-30 12:38 UTC (History)
1 user (show)

See Also:

Attachments
Patch to be added to /usr/ports/audio/amsynth/files (2.31 KB, text/plain)
2024-04-26 21:09 UTC, Patrick TJ McPhee 		no flags Details
patch to update the port Makefile (531 bytes, patch)
2024-04-26 21:10 UTC, Patrick TJ McPhee 		no flags Details | Diff
patch to update the port Makefile & distinfo to install version 1.13.3 (996 bytes, patch)
2024-04-26 22:02 UTC, Patrick TJ McPhee 		no flags Details | Diff
Clean up / add lv2 dep (3.65 KB, patch)
2024-04-28 09:56 UTC, Nuno Teixeira 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick TJ McPhee 2024-04-26 21:09:45 UTC 
Created attachment 250247 [details]
Patch to be added to /usr/ports/audio/amsynth/files

audio/amsynth is currently marked broken because of a callback function signature change in one of its dependencies, audio/liblo.

Current version of the port is 1.11.0. The issue is fixed in 1.13.3, but I haven't tried building that yet. The attachments make the build work with the current version. They consist of a patch file to be added to the port and a diff to be applied to the Makefile (updates portrevision and removes broken).
Comment 1 Patrick TJ McPhee 2024-04-26 21:10:51 UTC 
Created attachment 250248 [details]
patch to update the port Makefile
Comment 2 Patrick TJ McPhee 2024-04-26 22:02:30 UTC 
Created attachment 250250 [details]
patch to update the port Makefile & distinfo to install version 1.13.3

The latest version builds cleanly. I've done minimal testing with a umidi keyboard but it appears to work correctly.

I'll change the bug synopsis to indicate port is being upgraded.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-27 14:51:44 UTC 
Hello,

Port doesn't have a maintainer. Are you willing to maintain it?

Thanks
Comment 4 Patrick TJ McPhee 2024-04-27 20:58:33 UTC 
Sure. I'll keep an eye on new releases.
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-27 21:23:59 UTC 
I will do some testing on dependencies for a cleanup and then upload a patch so you can take a look.

Cheers
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-28 09:56:52 UTC 
Created attachment 250279 [details]
Clean up / add lv2 dep

- Remove GNU_CONFIGURE_MANPREFIX after 9fd7ee1cdf6c
- Add audio/lv2 build dep as upstream don't build bundled anymore
- Pet portlint, portclippy and portfmt
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-28 09:58:50 UTC 
Currently broken on 15 but I'm still doing tests.

Could you do a run test on this diff so we can proceed?

Cheers
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-30 09:07:45 UTC 
(In reply to Patrick TJ McPhee from comment #4)

Hello,

I will need to take maintainership temporarily on this port to investigate 15 (main) build failures.

Cheers
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-04-30 12:18:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c391004af0eee740c8b772d59c8de7778824b305

commit c391004af0eee740c8b772d59c8de7778824b305
Author:     Patrick TJ McPhee <ptjm@interlog.com>
AuthorDate: 2024-04-30 12:10:33 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-04-30 12:17:08 +0000

    audio/amsynth: Update to 1.13.3

    - Add audio/lv2 build dep as upstream doesn't provide bundled anymore
    - Pet portlint, portclippy and portfmt
    - Take maintainership for the time being

    PR:             278599

 audio/amsynth/Makefile  | 19 ++++++++-----------
 audio/amsynth/distinfo  |  6 +++---
 audio/amsynth/pkg-plist | 14 +++++++++++---
 3 files changed, 22 insertions(+), 17 deletions(-)
Comment 11 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-30 12:38:08 UTC 
Committed, thanks!