Bug 278735 - deskutils/nextcloudclient: Update to 3.13.0
Summary: deskutils/nextcloudclient: Update to 3.13.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Reifenberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 13:29 UTC by Guido Falsi
Modified: 2024-05-07 18:24 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mr)

Attachments
patch v1 (12.85 KB, patch)
2024-05-04 13:29 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2024-05-04 13:29:47 UTC 
Created attachment 250366 [details]
patch v1

Hi!

I've tested the attached update to 3.13.0.

It works fine here, and builds fine in poudriere for supported releases.

The patch also removes a bunch of PORTSDOCS from the plist. Poudriere reports duplicated files.

I think these files are already handled by the DOCS_VARS=              PORTDOCS=* part of the Makefile that adds content of DOCSDIR to the plist automatically.

Thanks in advance for any feedback!
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-04 22:20:57 UTC 
(In reply to Guido Falsi from comment #0)
Hello!

You removed all DOCS - is it correct?
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2024-05-04 22:44:25 UTC 
(In reply to Vladimir Druzenko from comment #1)

It is explained in  comment #0

Poudriere was reporting duplicated files.

The docs are added automatically to the plist thanks to "DOCS_VARS= PORTDOCS=*" which adds everything in DOCSDIR automatically:

https://docs.freebsd.org/en/books/porters-handbook/book/#install-documentation
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-04 23:06:35 UTC 
(In reply to Guido Falsi from comment #2)
Sorry, I don’t understand how I managed to miss this line when reading this post…
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2024-05-04 23:43:58 UTC 
(In reply to Vladimir Druzenko from comment #3)

No problem! :)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-05-07 14:30:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a3136faade21a9cfb7ab89b0db1ecb6c68f6504b

commit a3136faade21a9cfb7ab89b0db1ecb6c68f6504b
Author:     Michael Reifenberger <mr@FreeBSD.org>
AuthorDate: 2024-05-07 14:28:00 +0000
Commit:     Michael Reifenberger <mr@FreeBSD.org>
CommitDate: 2024-05-07 14:30:18 +0000

    deskutils/nextcloudclient: Update to 3.13.0

    PR:             278735
    Reported by:    Guido Falsi

 deskutils/nextcloudclient/Makefile  |   2 +-
 deskutils/nextcloudclient/distinfo  |   6 +-
 deskutils/nextcloudclient/pkg-plist | 197 ------------------------------------
 3 files changed, 4 insertions(+), 201 deletions(-)
Comment 6 Michael Reifenberger freebsd_committer freebsd_triage 2024-05-07 18:24:47 UTC 
Committed,
Thanks!