Bug 278779 - x11-fonts/cascadia-code: Update to 2404.23
Summary: x11-fonts/cascadia-code: Update to 2404.23
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/microsoft/cascadia...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-05 09:21 UTC by Daniel Engberg
Modified: 2024-06-07 19:40 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for cascadia-code (3.16 KB, patch)
2024-05-05 09:21 UTC, Daniel Engberg 		no flags Details | Diff
Patch for cascadia-code v2 (3.20 KB, patch)
2024-05-05 17:56 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 09:21:47 UTC 
Created attachment 250419 [details]
Patch for cascadia-code

Use (bsd)tar to extract and exclude unused files, saves significant I/O
While at it adjust Makefile to follow Porters Handbook more closely

Poudriere testport OK on FreeBSD 13.2-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 17:56:50 UTC 
Created attachment 250467 [details]
Patch for cascadia-code v2

Preserve original flags
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-22 02:19:11 UTC 
Updated to 2404.23 in ports 354103e4dd130daf19a858fef9ae3ad4c9669815.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-06-06 19:08:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9a22dceae54e0236da83ce52cfee4af1af99d0aa

commit 9a22dceae54e0236da83ce52cfee4af1af99d0aa
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-06-06 06:36:15 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-06-06 19:05:48 +0000

    x11-fonts/cascadia-code: Use EXTRACT_AFTER_ARGS to reduce I/O

    Use EXTRACT_AFTER_ARGS to reduce I/O more than 50% by only extracting
    files we install.

    PR:             278779
    Approved by:    blanket (improvment to build)

 x11-fonts/cascadia-code/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-06-06 20:43:41 UTC 
As I said in other PR, I really do not like the idea to have hardcoded EXTRACT_AFTER_ARGS.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-06-06 21:13:05 UTC 
There's clearly an issue with communication and your actions. If you're unable to respond, address PRs and reviews a workflow and/or workload needs to be changed as it's a joint effort.

That being said, what's your justification for making this port unnecessarily heavy for everyone with a simple fix?
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-06-07 19:40:01 UTC 
You did however commit it and shuffling around ~100Mbyte just for the sake of it isn't very efficient on resources.