Bug 279158 - security/xhash: Bump to v3.3.3, go122 and latest dependencies PR:263
Summary: security/xhash: Bump to v3.3.3, go122 and latest dependencies PR:263
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/ricardobranco777/x...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-19 11:36 UTC by Ricardo Branco
Modified: 2024-05-21 10:32 UTC (History)
2 users (show)

See Also:


Attachments
0001-security-xhash-Bump-to-v3.3.3-go122-and-latest-depen.patch (2.89 KB, patch)
2024-05-19 12:28 UTC, Ricardo Branco
no flags Details | Diff
0001-security-xhash-Bump-to-v3.3.3-go122-and-latest-depen.patch (2.89 KB, patch)
2024-05-19 12:41 UTC, Ricardo Branco
no flags Details | Diff
0001-security-xhash-Bump-to-v3.3.3-go122-and-latest-depen.patch (2.80 KB, patch)
2024-05-20 14:17 UTC, Ricardo Branco
rbranco: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo Branco 2024-05-19 11:36:26 UTC
https://github.com/freebsd/freebsd-ports/pull/263
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-05-19 11:36:26 UTC
Maintainer informed via mail
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-19 12:19:16 UTC
Hi,

Submit a patch using bugzilla, PRs on GitHub are not actively monitored or supported. https://docs.freebsd.org/en/books/porters-handbook/book/#port-upgrading

Best regards,
Daniel
Comment 3 Ricardo Branco 2024-05-19 12:28:01 UTC
Created attachment 250808 [details]
0001-security-xhash-Bump-to-v3.3.3-go122-and-latest-depen.patch

Attached patch.
Comment 4 Ricardo Branco 2024-05-19 12:41:02 UTC
Created attachment 250809 [details]
0001-security-xhash-Bump-to-v3.3.3-go122-and-latest-depen.patch
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-20 14:06:20 UTC
Q/A: PORTREVISION should be removed

Thanks!
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-20 14:08:28 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Thanks!
Comment 7 Ricardo Branco 2024-05-20 14:17:11 UTC
Created attachment 250829 [details]
0001-security-xhash-Bump-to-v3.3.3-go122-and-latest-depen.patch

Changes in this new patch vs. the old-one:
- Still use Go 1.21 because Go 1.22 still has some CGO issues with 32-bit arches.  (It failed for me on NetBSD i386 but not FreeBSD, I don't know why).
- Commented PORTREVISION

Changelog for package:
https://github.com/ricardobranco777/xhash/compare/v3.3.2...v3.3.3
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-20 14:21:17 UTC
(In reply to Ricardo Branco from comment #7)
Thanks for the update.
It is better to remove PORTREVISION than leave it commented out :-)
Do not upload a new patch, I will remove it before commit time.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-21 10:31:21 UTC
Committed,

Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-05-21 10:32:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=93f697098473775b1e35c6ab24e21dad44b23313

commit 93f697098473775b1e35c6ab24e21dad44b23313
Author:     Ricardo Branco <rbranco@suse.com>
AuthorDate: 2024-05-20 14:22:29 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-05-21 10:30:44 +0000

    security/xhash: update to v3.3.3

    ChangeLog: https://github.com/ricardobranco777/xhash/compare/v3.3.2...v3.3.3

    PR:             279158
    Reported by:    rbranco@suse.com (maintainer)

 security/xhash/Makefile |  9 ++++-----
 security/xhash/distinfo | 14 +++++++-------
 2 files changed, 11 insertions(+), 12 deletions(-)