Created attachment 250937 [details] git diff against sysutils/thefish It's been awhile. Time to update the source, move it to codeberg. While here; improve Makefile, and remove (now) unnecessary patch files in files/. That's it! Thanks. --Chris
Hi Chris, what differs if GTK2 selected or not? As I see nothing. I think the MAKE_ENV should be GTK2_MAKE_ENV (see https://docs.freebsd.org/en/books/porters-handbook/book/#options-variables). The USE_GNOME is always used (doesn't matter GTK2 is set or unset). And X11 is unnecessary. Add LICENSE_FILE as Porter's Handbook suggests (https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license). In the project Makefile appears WITH_QT (https://codeberg.org/BSDforge/thefish/src/branch/main/Makefile#L16). Do you want add QT option? Are the GTK, QT and ncurses frontends mutually exclusive options? Or can set all and can choose frontend at runtime (for example --gtk or --qt or --ncurses)?
And please use portfmt -D Makefile and switch to DISTVERSION (from PORTVERSION). Thanks!
(In reply to Zsolt Udvari from comment #1) Ok, I checked the history of commits. Several years ago could choose between GTK and QT3. But now the QT3 is unsupported so only the GTK remains. So no choose :) Suggestion: remove the options.
Thanks for taking the time to review this. Sorry for the delay. I seem to have missed the emails. I'll provide another patch reflecting your suggestions sometime today. Thanks again.
Created attachment 251823 [details] updated git diff against sysutils/thefish OK. This patch reflects changes based on your comments. Thanks! :) --Chris
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=70a67dbdf65a214e42854ff125fb8f1a56089346 commit 70a67dbdf65a214e42854ff125fb8f1a56089346 Author: Chris Hutchinson <portmaster@bsdforge.com> AuthorDate: 2024-07-02 05:22:37 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-07-02 05:26:12 +0000 sysutils/thefish: Update to 0.6.8 Remove options because can choose between GTK2 and Qt3, Qt3 is outdated. Project moves to codeberg. Switch to DISTVERSION. Add LICENSE_FILE. PR: 279282 Approved by: Submitter is maintainer sysutils/thefish/Makefile | 27 +++++++++++++-------------- sysutils/thefish/distinfo | 5 +++-- sysutils/thefish/files/patch-Makefile (gone) | 25 ------------------------- sysutils/thefish/files/patch-main.c (gone) | 22 ---------------------- 4 files changed, 16 insertions(+), 63 deletions(-)
Committed, thanks!