Bug 279357 - Remove unused and non-portable rune_t
Summary: Remove unused and non-portable rune_t
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: standards (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-28 00:56 UTC by Brooks Davis
Modified: 2024-06-03 20:18 UTC (History)
1 user (show)

See Also:
antoine: exp-run+


Attachments
Remove rune_t typedefs (1.49 KB, text/plain)
2024-05-28 00:56 UTC, Brooks Davis
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2024-05-28 00:56:25 UTC
Created attachment 251030 [details]
Remove rune_t typedefs

This type is unused in the base system and nothing should be using it. Let's do an exp-run to find out.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2024-05-31 18:28:13 UTC
Exp-run seems fine
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-02 18:43:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=39c4f65c72c7bd00546b4571b3bbe0432162efa3

commit 39c4f65c72c7bd00546b4571b3bbe0432162efa3
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2024-06-02 18:39:30 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2024-06-02 18:41:22 +0000

    stddef.h/stdlib.h: Remove unused rune_t

    This non-standard type is unused in the base system (__ct_rune_t or
    __rune_t are used instead) and ports.  It has been around as long as our
    current source repo, but we have avoided using it.  In sys/_types.h
    where the __*rune_t typedefs are defined, the following appears in a
    comment:

        NOTE: rune_t is not covered by ANSI nor other standards, and should
        not be instantiated outside of lib/libc/locale.  Use wchar_t.

    The definition of this unused type meant we gratutiously differed from
    standards compliant stddef.h/stdlib.h.

    PR:             279357 (exp-run by antoine)

    Reviewed by:    imp, emaste
    Differential Revision:  https://reviews.freebsd.org/D45426

 include/stddef.h | 7 -------
 include/stdlib.h | 7 -------
 2 files changed, 14 deletions(-)
Comment 3 Brooks Davis freebsd_committer freebsd_triage 2024-06-03 20:18:07 UTC
Thank you to antoine for the exp-run.