Bug 279386 - japanese/skkinput3: Remove invalid option
Summary: japanese/skkinput3: Remove invalid option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-29 21:00 UTC by mew14930xvi
Modified: 2024-07-02 22:31 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (koma2)


Attachments
Remove invalid option (1.78 KB, patch)
2024-05-29 21:00 UTC, mew14930xvi
no flags Details | Diff
+ some tweaks (3.18 KB, patch)
2024-06-30 15:49 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2024-05-29 21:00:07 UTC
Created attachment 251069 [details]
Remove invalid option

Remove RSKKSERV option (Depends on japanese/rskkserv expired in 2014-09)
Add LICENSE
Add japanese/skkserv option
If not selected in the options, do not install dictionary server
Switch post-install to post-install-DOCS-on
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-30 15:02:21 UTC
Maintainer timeout > 1 month.

I can build it in poudriere and commit, but I can't test it.
Did you test build and work port with all combinations of options?
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-30 15:49:42 UTC
Created attachment 251801 [details]
+ some tweaks

* Bump - default options changed.
* Sort options (pet portclippy).
* Regenerate patches (pet portlint).
* Add OPTIONS_SUB=yes and remove SKK10=*.

We can replace SKK8=* with option SKK8 in SINGLE with SKK10 if you can write text for SKK8_DESC:
OPTIONS_DEFINE=                DOCS
OPTIONS_DEFAULT=               SKK9
OPTIONS_RADIO=                 SKKSERVER
OPTIONS_RADIO_SKKSERVER=       DBSKKD SKK9
OPTIONS_SINGLE=                SKK8_10
OPTIONS_SINGLE_SKK8_10=        SKK10 SKK8
OPTIONS_SUB=                   yes

DBSKKD_DESC=    Use ja-dbskkd-cdb as skkserver
SKK10_DESC=     Install SKK10 elisp files
SKK8_10_DESC=   ??????
SKK8_DESC=      ??????
SKK9_DESC=      Use ja-skkserv as skkserver
SKKSERVER_DESC= Skkserver selection
Comment 3 mew14930xvi 2024-07-02 18:15:41 UTC
skkinput3 is an error on amd64.
If long is changed to int, the error disappears but no characters can be entered.
I tried the i386 binary, but only some of the functions are available.
I searched the internet but found no information.
So I tried to see if the maintainer would respond.
This was a copy and paste of skkinput's report(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279374).
(I have been using japanese/skkinput for over 20 years, but had not tried 3.0)
I was wrong.
Sorry for wasting your time.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-02 18:25:17 UTC
(In reply to mew14930xvi from comment #3)
We can freeze this and commit https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279374
What do you think?
Comment 5 mew14930xvi 2024-07-02 18:38:58 UTC
Yes.
That is fine.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-07-02 22:27:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=246e3def00512d3a051bfba77b2725f96a070b86

commit 246e3def00512d3a051bfba77b2725f96a070b86
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2024-07-02 22:23:17 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-02 22:26:17 +0000

    japanese/skkinput3: Remove invalid option

    Remove RSKKSERV option (Depends on japanese/rskkserv expired in 2014-09)
    Add LICENSE
    Add japanese/skkserv option
    If not selected in the options, do not install dictionary server
    Switch post-install to post-install-DOCS-on
    Sort options (pet portclippy)
    Regenerate patches (pet portlint)
    Add OPTIONS_SUB=yes and remove SKK10=*

    PR:             279386
    Approved by:    koma2@lovepeers.org (maintainer, timeout > 1 month)

 japanese/skkinput3/Makefile                  | 44 ++++++++++++++--------------
 japanese/skkinput3/distinfo                  |  1 +
 japanese/skkinput3/files/patch-Imakefile     |  6 ++--
 japanese/skkinput3/files/patch-Skkinput.conf |  6 ++--
 4 files changed, 29 insertions(+), 28 deletions(-)
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-02 22:31:03 UTC
I decided that "Remove invalid option" was still necessary. And also that I don’t want to lose my work.