Bug 279407 - multimedia/dvdstyler: update to 3.3b4
Summary: multimedia/dvdstyler: update to 3.3b4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-30 18:34 UTC by Alan Hicks
Modified: 2024-05-31 10:26 UTC (History)
1 user (show)

See Also:
ahicks: maintainer-feedback+

Attachments
Patch to upgrade dvdstyler to 3.3b4 (4.40 KB, patch)
2024-05-30 18:34 UTC, Alan Hicks 		ahicks: maintainer-approval+
Details | Diff
Poudriere build log (254.54 KB, text/plain)
2024-05-30 18:35 UTC, Alan Hicks 		ahicks: maintainer-approval+
Details
Updated patch to 3.3b4 (5.18 KB, patch)
2024-05-31 05:32 UTC, Alan Hicks 		ahicks: maintainer-approval+
Details | Diff
Updated log with stage-qa (258.30 KB, text/plain)
2024-05-31 05:34 UTC, Alan Hicks 		ahicks: maintainer-approval+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Hicks 2024-05-30 18:34:27 UTC 
Created attachment 251096 [details]
Patch to upgrade dvdstyler to 3.3b4

This is a minor upgrade incorporating this ports patches so they are no longer required.
Comment 1 Alan Hicks 2024-05-30 18:35:37 UTC 
Created attachment 251097 [details]
Poudriere build log

Poudriere build log
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-30 22:41:54 UTC 
poudriere 13.3 amd64:
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%DATADIR%%/buttons/star.xml
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

I think you forgot add pkg-plist in patch:
--- multimedia/dvdstyler.orig/pkg-plist
+++ multimedia/dvdstyler/pkg-plist
@@ -116,6 +116,7 @@ share/applications/dvdstyler.desktop
 %%DATADIR%%/buttons/pill3.xml
 %%DATADIR%%/buttons/settings.xml
 %%DATADIR%%/buttons/star-frame.xml
+%%DATADIR%%/buttons/star.xml
 %%DATADIR%%/buttons/sticky_note.xml
 %%DATADIR%%/buttons/stone.xml
 %%DATADIR%%/buttons/text-circle-v2.xml

Also probably better to replace
> USES=gettext
with
> USES=gettext-tools
Comment 3 Alan Hicks 2024-05-31 05:32:13 UTC 
Created attachment 251106 [details]
Updated patch to 3.3b4

Updated patch
Thanks Vladimir for the qa-check and heads up on gettext-tools
Comment 4 Alan Hicks 2024-05-31 05:34:07 UTC 
Created attachment 251107 [details]
Updated log with stage-qa

Successful build log with Q/A tests (stage-qa)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-05-31 10:24:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8a4631667cd60e3f76c6a5e81ffa13eb362a7a5a

commit 8a4631667cd60e3f76c6a5e81ffa13eb362a7a5a
Author:     Alan Hicks <ahicks@p-o.co.uk>
AuthorDate: 2024-05-31 10:14:39 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-05-31 10:14:39 +0000

    multimedia/dvdstyler: update to 3.3b4

    This is a minor upgrade incorporating this ports patches so they are no
    longer required.

    Version 3.3 beta 4 <2024-05-26>
    * updated ffmpeg to version 7.0

    Changelog:
    https://sourceforge.net/projects/dvdstyler/files/dvdstyler-devel/3.3b4/

    PR:             279407

 multimedia/dvdstyler/Makefile                                |  6 ++----
 multimedia/dvdstyler/distinfo                                |  6 +++---
 multimedia/dvdstyler/files/patch-docs-Makefile.in (gone)     | 11 -----------
 .../dvdstyler/files/patch-src_mediaenc__ffmpeg.cpp (gone)    | 12 ------------
 .../files/patch-wxVillaLib_ThumbnailFactory.cpp (gone)       | 11 -----------
 .../dvdstyler/files/patch-wxVillaLib_imagjpg.cpp (gone)      | 10 ----------
 .../dvdstyler/files/patch-wxVillaLib_thumb_md5.cpp (gone)    | 11 -----------
 multimedia/dvdstyler/pkg-plist                               |  1 +
 8 files changed, 6 insertions(+), 62 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-31 10:26:51 UTC 
Please add some info about new version for commit log.

Thanks!