Bug 279472 - graphics/opensubdiv: sort out Makefile, pet portclippy, fix build on 32bit
Summary: graphics/opensubdiv: sort out Makefile, pet portclippy, fix build on 32bit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-02 17:29 UTC by Vladimir Druzenko
Modified: 2024-06-03 10:50 UTC (History)
1 user (show)

See Also:
FreeBSD: maintainer-feedback+

Attachments
v1 (9.31 KB, patch)
2024-06-02 17:29 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-02 17:29:44 UTC 
Created attachment 251163 [details]
v1

Tested build in poudriere (testport) 13.3 amd64, i386 and on live system 13.3 amd64.

- Remove unnecessary libs from USE_GL and add used.
- Fix build on 32bit ARCHS, upstream issue: https://github.com/PixarAnimationStudios/OpenSubdiv/issues/1198#issuecomment-2143940211
- Make options PTEX and OPENMP (for supported ARCHS) default.
- EXAMPLES and OPENCL can build together without errors.
- Remove NO_GL_TESTS - upstream removed it.
- Sort options and pet portclippy.
Comment 1 Shane 2024-06-03 10:23:20 UTC 
Comment on attachment 251163 [details]
v1

looks ok
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-03 10:49:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f251a78efa6eb44e9d97fd520247d3494754f7c8

commit f251a78efa6eb44e9d97fd520247d3494754f7c8
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-06-03 10:46:50 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-06-03 10:46:50 +0000

    graphics/opensubdiv: sort out Makefile, pet portclippy, fix build on 32bit

    - Remove unnecessary libs from USE_GL and add required.
    - Fix build on 32bit ARCHS, upstream issue:
    https://github.com/PixarAnimationStudios/OpenSubdiv/issues/1198#issuecomment-2143940211
    - Make options OPENMP (for supported ARCHS) and PTEX default.
    - EXAMPLES and OPENCL can build together without errors.
    - Remove NO_GL_TESTS - upstream removed it.
    - Sort options and pet portclippy.

    PR:             279472
    Approved by:    Shane <FreeBSD@ShaneWare.Biz> (maintainer)

 graphics/opensubdiv/Makefile                       | 51 +++++++++++-----------
 .../files/patch-examples_CMakeLists.txt (gone)     | 12 -----
 .../files/patch-opensubdiv_hbr_mesh.h (new)        | 11 +++++
 .../files/patch-opensubdiv_osd_CMakeLists.txt      |  8 ++--
 .../files/patch-regression_CMakeLists.txt (gone)   | 22 ----------
 .../files/patch-tutorials_CMakeLists.txt (gone)    | 12 -----
 graphics/opensubdiv/pkg-plist                      | 20 ++++-----
 7 files changed, 51 insertions(+), 85 deletions(-)