Created attachment 251496 [details] Patch for iniparser Switch to CMake which cleans up port and makes it more friendly for other consumers Compile tested on FreeBSD 14.0-RELEASE (amd64) (make, make check-plist) Poudriere testport OK 13.2-RELEASE (amd64) Poudriere testport OK 14.1-RELEASE (amd64)
Hello Daniel, Thanks!
Ahh, you can rip ou the TEST_DEPENDS as it now requires unity which we dont seem to have ported... https://github.com/ndevilla/iniparser/blob/main/test/CMakeLists.txt#L27 https://github.com/throwtheswitch/unity Best regards, Daniel
(In reply to Daniel Engberg from comment #2) Ok. documentation talks about tests: mkdir build cd build cmake -DBUILD_TESTS .. make all amaybe we shoud try cmake:testing to check if it works
It doesn't because it can't find unity
(In reply to Daniel Engberg from comment #4) Ok, please commit it without test dep then. I will take a look at unity test and see if it is worth to be ported. Cheers
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9d96527a928006f4b8f76ffa3d65c695168d9905 commit 9d96527a928006f4b8f76ffa3d65c695168d9905 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-06-16 16:32:25 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-06-16 16:35:53 +0000 devel/iniparser: Update to 4.2.4 * Switch to CMake which cleans up Makefile and makes port more easily available for consumers * Drop "make test" due to new and unported dependencies Changelog: https://github.com/ndevilla/iniparser/releases/tag/v4.2.4 PR: 279782 Reviewed by: eduardo (maintainer) devel/iniparser/Makefile | 27 +++++++++------------------ devel/iniparser/distinfo | 6 +++--- devel/iniparser/pkg-plist (new) | 13 +++++++++++++ 3 files changed, 25 insertions(+), 21 deletions(-)
Committed, thanks!