Bug 279862 - net-mgmt/alertmanager: Make daemon close file descriptors on start
Summary: net-mgmt/alertmanager: Make daemon close file descriptors on start
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: michal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-19 14:47 UTC by Michael Gmelin
Modified: 2024-07-13 11:39 UTC (History)
1 user (show)

See Also:
michal: maintainer-feedback+

Attachments
Patch to pass -f to daemon (1.00 KB, patch)
2024-06-19 14:47 UTC, Michael Gmelin 		grembo: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer freebsd_triage 2024-06-19 14:47:14 UTC 
Created attachment 251575 [details]
Patch to pass -f to daemon

Writing to stderr/stdout is not useful and can cause issues when "service alertmanager restart" is called from a forked process (as it keeps stderr/stdout open). In my case this caused processes to hand in "piperd".
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-07-12 14:17:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ed9383601bf09428e220e755dcee344f2cbb9df

commit 9ed9383601bf09428e220e755dcee344f2cbb9df
Author:     Michael Gmelin <grembo@FreeBSD.org>
AuthorDate: 2024-07-12 13:41:43 +0000
Commit:     Michael Gmelin <grembo@FreeBSD.org>
CommitDate: 2024-07-12 14:16:02 +0000

    net-mgmt/alertmanager: Make daemon close file descriptors on start

    Prevents alertmanager from hanging in piperd.

    PR:             279862
    Approved by:    maintainer timeout

 net-mgmt/alertmanager/files/alertmanager.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)