Bug 279897 - graphics/mapserver: Dependency fails to build with libxml2 2.13.1
Summary: graphics/mapserver: Dependency fails to build with libxml2 2.13.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks: 279705 279955
  Show dependency treegraph
 
Reported: 2024-06-21 19:35 UTC by Daniel Engberg
Modified: 2024-07-04 21:54 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
Patch for mapserver (10.82 KB, patch)
2024-06-23 11:03 UTC, Daniel Engberg
no flags Details | Diff
Patch for mapserver v2 (10.89 KB, patch)
2024-06-23 11:09 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-06-21 19:35:26 UTC
As far as I can tell libsvg is at best abandonware and fails to build, can we possibly move to librsvg instead?
https://github.com/MapServer/MapServer/blob/rel-8-0-2/CMakeLists.txt#L156

Reference:
https://pdr2.bofh.network/data/140-diizzy/libxml2-2131/logs/errors/libsvg-0.1.4_11.log
Comment 1 Wen Heping freebsd_committer freebsd_triage 2024-06-21 23:14:04 UTC
(In reply to Daniel Engberg from comment #0)
Feel free to improve this port.
Thank you !
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-06-23 11:03:13 UTC
Created attachment 251639 [details]
Patch for mapserver

* Modernize Makefile
* Reduce amount of options and align port to closer match other distros in terms of functionality
* Switch to libsvr2
* Remove invalid options (such as PHP)
* Prefix binaries
* Use framework helpers for INSTALL sections

Compile tested on FreeBSD 14.0-RELEASE (amd64) (make, make check-plist)

Poudriere testport OK 13.2-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-06-23 11:04:44 UTC
err libsvr3 --> librsvg2

This should make it much easier to maintain in general
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-06-23 11:09:53 UTC
Created attachment 251640 [details]
Patch for mapserver v2

Add missing build dep for PERL and PYTHON options
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-07-03 18:32:02 UTC
Wen, is the rework to commit or do you want to do some changes?
Comment 6 Wen Heping freebsd_committer freebsd_triage 2024-07-03 23:29:36 UTC
(In reply to Daniel Engberg from comment #5)
Approved.
Thank you !
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-07-04 21:53:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0f1b848156286e5121019b5d18ff3461ef543657

commit 0f1b848156286e5121019b5d18ff3461ef543657
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-07-04 21:49:53 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-07-04 21:50:03 +0000

    graphics/mapserver: Improve port

    * Modernize Makefile
    * Reduce amount of options and align port to closer match other
      distros in terms of functionality
    * Switch to from libsvg to librsvg2
    * Remove invalid options (such as PHP)
    * Prefix binaries
    * Use framework helpers for INSTALL sections

    PR:             279897
    Reviewed by:    wen (maintainer)

 graphics/mapserver/Makefile  | 334 ++++++++++++++++---------------------------
 graphics/mapserver/pkg-plist |  20 ++-
 2 files changed, 135 insertions(+), 219 deletions(-)
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2024-07-04 21:54:03 UTC
Committed, thanks!