Bug 280212 - Highpoint drivers (hptrr, etc) missing from 13.x
Summary: Highpoint drivers (hptrr, etc) missing from 13.x
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.3-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Andrew Turner
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-07-10 02:10 UTC by William F. Dudley Jr.
Modified: 2024-07-29 16:14 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William F. Dudley Jr. 2024-07-10 02:10:48 UTC
The hptrr and related HighPoint kernel modules are missing from 13.3.
No modules in /boot/kernel
No mention in /usr/src/sys/amd64/GENERIC 
The only evidence that they shoud exist is the man pages.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-10 18:16:44 UTC
Looks like a bug in the distribution.
14.1 have modules for all 4 drivers: hpt27xx hptmv hptnr hptrr.
The sources of version 13.3 also have all 4 drivers (sys/dev/), but they are not in /boot/kernel/…
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-10 20:39:12 UTC
William F. Dudley Jr., if you can't apply patch and build modules self from sources you can get file hptrr.ko from FreeBSD 13.2 installation media as a temporary workaround.
Comment 4 Herbert J. Skuhra 2024-07-10 22:01:52 UTC
(In reply to Vladimir Druzenko from comment #3)
Sorry, but have you checked the suggested workaround?
The drivers are obviously missing on all 13.x releases:

$ curl -O http://ftp-archive.freebsd.org/pub/FreeBSD-Archive/old-releases/amd64/13.2-RELEASE/kernel.txz
$ tar -tzf kernel.txz  |grep hpt
./boot/kernel/hptiop.ko
$ curl -O http://ftp-archive.freebsd.org/pub/FreeBSD-Archive/old-releases/amd64/13.1-RELEASE/kernel.txz
$ tar -tzf kernel.txz  |grep hpt
./boot/kernel/hptiop.ko
$ curl -O http://ftp-archive.freebsd.org/pub/FreeBSD-Archive/old-releases/amd64/13.0-RELEASE/kernel.txz
$ tar -tzf kernel.txz  |grep hpt
./boot/kernel/hptiop.ko
$ curl -O http://ftp-archive.freebsd.org/pub/FreeBSD-Archive/old-releases/amd64/14.0-RELEASE/kernel.txz
$ tar -tzf kernel.txz  |grep hpt
./boot/kernel/hptiop.ko
./boot/kernel/hptnr.ko
./boot/kernel/hptrr.ko
./boot/kernel/hpt27xx.ko
./boot/kernel/hptmv.ko
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2024-07-10 22:07:55 UTC
^Triage: notify committer of commit in question.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-10 22:48:59 UTC
(In reply to Herbert J. Skuhra from comment #4)
Sorry, this was just an assumption - I didn’t have time to check it yet…
So I was wrong. :-(
Comment 7 Mark Johnston freebsd_committer freebsd_triage 2024-07-12 17:28:01 UTC
Indeed, we don't build these drivers when !empty(KCSAN_ENABLED).  Maybe there is a missing MFC to stable/13 of some KCSAN build support?
Comment 9 Herbert J. Skuhra 2024-07-29 11:43:52 UTC
Will this be merged for releng/13.4?
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-07-29 16:13:03 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c8701777c0e8654f060e46b067dd86452f48c364

commit c8701777c0e8654f060e46b067dd86452f48c364
Author:     Andrew Turner <andrew@FreeBSD.org>
AuthorDate: 2021-06-02 10:07:55 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-07-29 16:10:50 +0000

    Fix the KCSAN_ENABLED check when building modules

    The KCSAN_ENABLED variable is non-empty when the kernel is being built
    with KCSAN. This allows us to disable modules that are known to be
    broken.

    There was a bug where we would check if it was defined. As this is
    always the case the KCSAN_ENABLED variable would be set when building
    modules so we would never build such a module. Fix this by checking
    if the value is empty before passing it on to the module stage.

    This doesn't affect how modules are built as the CFLAGS passed to
    modules has the correct check.

    PR:             280212
    Reported by:    rstone
    Sponsored by:   Innovate UK

    (cherry picked from commit 2422138952d86dd8b02ff33c55f747ca8e381afe)

 sys/conf/kern.post.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 11 Mark Johnston freebsd_committer freebsd_triage 2024-07-29 16:14:11 UTC
(In reply to Herbert J. Skuhra from comment #9)
Yes, this is now fixed in stable/13 and will be in releng/13.4.

Thank you for the report.