Bug 280217 - archivers/lxqt-archiver: package has less dependencies than the port requires (14)
Summary: archivers/lxqt-archiver: package has less dependencies than the port requires...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: LXQT Mailing List (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-10 14:05 UTC by Kevin Reinholz
Modified: 2024-09-10 05:51 UTC (History)
4 users (show)

See Also:
linimon: maintainer-feedback? (lxqt)


Attachments
Proposed Makefile patch (398 bytes, patch)
2024-07-18 14:29 UTC, Kevin Reinholz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Reinholz 2024-07-10 14:05:32 UTC
Build system info:

FreeBSD 14.1-STABLE (amd64)
Kernel Version 1401501, Userland Version 1401501, Revision n267971
synth-2.13_2
LLVM version 18.1.6

Building archivers/lxqt-archiver with ports-mgmt/synth results in the following obsolete packages warning being logged:

archivers/lxqt-archiver package has less dependencies than the port requires (14)

devel/desktop-file-utils:desktop-file-utils-0.27
devel/gettext-runtime:gettext-runtime-0.22.5
devel/glib20:glib-2.80.3,2
archivers/gtar:gtar-1.35_1
devel/json-glib:json-glib-1.8.0
graphics/libexif:libexif-0.6.24
x11/libfm-qt6:libfm-qt6-2.0.2
devel/liblxqt:liblxqt-2.0.0
devel/libqt6xdg:libqt6xdg-4.0.0
x11/libxcb:libxcb-1.17.0
x11/menu-cache:menu-cache-1.1.0
lang/perl5.36:perl5-5.36.3_1
devel/qt6-base:qt6-base-6.7.2

This warning began when lxqt-archiver was updated from version 0.8.0 to 0.9.0, and continues with the current version 1.0.0.

The culprit appears to be the following change to the Makefile:

diff --git a/archivers/lxqt-archiver/Makefile b/archivers/lxqt-archiver/Makefile
index 17bfb2616957..423836ef9c12 100644
--- a/archivers/lxqt-archiver/Makefile
+++ b/archivers/lxqt-archiver/Makefile
@@ -1,5 +1,5 @@
 PORTNAME=	lxqt-archiver
-PORTVERSION=	0.8.0
+PORTVERSION=	0.9.0
 CATEGORIES=	archivers
 MASTER_SITES=	LXQT
 
@@ -13,15 +13,14 @@ LIB_DEPENDS=	libfm-qt.so:x11/libfm-qt \
 		libjson-glib-1.0.so:devel/json-glib \
 		libmenu-cache.so:x11/menu-cache \
 		libexif.so:graphics/libexif
-RUN_DEPENDS=	${LOCALBASE}/bin/gtar:archivers/gtar \
-		${LOCALBASE}/bin/unzip:archivers/unzip
+RUN_DEPENDS=	gtar:archivers/gtar \
+		unzip:archivers/unzip

Previously, lxqt-archiver looked for gtar and unzip in /usr/local/bin, and dependencies were logged properly. However, starting with the above commit, it began searching for these binaries in /usr/bin, and falling back on /usr/local/bin only if not found in the base system.

gtar is not included in the FreeBSD 14.1 base system; unzip is. As a result, unzip doesn't get logged as a dependency, and synth logs a warning about lxqt-archiver having less dependencies than the port requires.

Reverting the run depends check for unzip to ${LOCALBASE}/bin/unzip:archivers/unzip results in synth correctly building lxqt-archiver and logging the appropriate dependencies, resolving this warning message.

Since unzip is included in the FreeBSD base system, this runtime dependency check could alternatively be eliminated from the Makefile altogether, unless it is always desired to build against the archivers/unzip port, which provides UnZip, as opposed to the base system bsdunzip.

Note: because I have x11-wm/lxqt in my prime packages list, the above dependency mismatch logs a warning but does not uninstall either lxqt-archiver or lxqt.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-07-10 14:05:32 UTC
Maintainer informed via mail
Comment 2 Kevin Reinholz 2024-07-18 14:29:58 UTC
Created attachment 252145 [details]
Proposed Makefile patch
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-10 05:50:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b024db732b302723f8ed31d820d9c8610439ce7

commit 3b024db732b302723f8ed31d820d9c8610439ce7
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2024-09-10 05:45:52 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2024-09-10 05:45:52 +0000

    archivers/lxqt-archiver: Fix unzip dependency

    - Add unzip dependency when OSVERSION is less of 14.1
    - Bump PORTREVISION

    PR:             280217
    Reported by:    Kevin Reinholz <kreinholz at_ gmail.com>

 archivers/lxqt-archiver/Makefile | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Comment 4 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-09-10 05:51:05 UTC
Committed thanks!