Bug 280272 - www/luakit: use portscout to skip date-based versions
Summary: www/luakit: use portscout to skip date-based versions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://portscout.freebsd.org/mew1493...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-14 11:27 UTC by Zsolt Udvari
Modified: 2024-07-15 18:43 UTC (History)
1 user (show)

See Also:
mew14930xvi: maintainer-feedback+


Attachments
luakit portscout (301 bytes, patch)
2024-07-14 11:27 UTC, Zsolt Udvari
no flags Details | Diff
portscout (294 bytes, patch)
2024-07-14 12:56 UTC, mew14930xvi
mew14930xvi: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2024-07-14 11:27:35 UTC
Created attachment 252039 [details]
luakit portscout

As you see portscout thinks the 2017.08.10 is the latest version (because 2017.08.10 is "newer" then 2.*).
Comment 1 mew14930xvi 2024-07-14 12:56:06 UTC
Created attachment 252042 [details]
portscout

I can't update any further until webkit2-gtk3 is updated.
Newer than www/luakit-devel will result in an error.
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-14 13:16:21 UTC
(In reply to mew14930xvi from comment #1)
If portscout reports an update it doesn't mean you should update.

The report of portscout in this case isn't real because luakit versioning changed. Check "pkg version -t 2.3 2017.02". So any new release (2.x) isn't newer than 2017.* so portscout doesn't send notification. I want change this with my suggestion.

So I don't suggest disable portscout (an example of disabling is mail/squirrelmail).
Comment 3 mew14930xvi 2024-07-14 14:21:25 UTC
What are the issues to be disabled?
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-14 15:36:06 UTC
(In reply to mew14930xvi from comment #3)
The squirellmail provides every day a subversion-snapshot (see https://squirrelmail.org/download.php - 1.4.23-svn) even if nothing changed (the last change was at 27 Mar 2024). If I don't disable it I receive a notification every day. See https://cgit.freebsd.org/ports/commit/mail/squirrelmail?id=949980c8475e0bb2691da53f451a78e1dc82d63d
Comment 5 mew14930xvi 2024-07-14 18:40:56 UTC
What problems do you have with portscout deeming 2017.08.10 as the latest?
Comment 6 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-14 18:53:21 UTC
(In reply to mew14930xvi from comment #5)
If you're the maintainer you will receive email from portscout if new version is released. You don't need check the webpage every day/week/... because of new release (and if you've many-many ports it'd take many time). It's an automatism.

Check https://portscout.freebsd.org/ and choose a maintainer which has positive value in "Ports with New Distfile(s)".

I hope my explanation is understandable.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-14 18:55:56 UTC
Relevant part of Porter's Handbook: https://docs.freebsd.org/en/books/porters-handbook/book/#distfile-survey
Comment 8 mew14930xvi 2024-07-14 19:15:46 UTC
So no one has a problem except the maintainer?
Comment 9 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 04:50:22 UTC
(In reply to mew14930xvi from comment #8)
Yes :)
Comment 10 mew14930xvi 2024-07-15 09:38:48 UTC
I have never received that notification.
All I have received is this PR special attention.
Comment 11 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 10:00:42 UTC
(In reply to mew14930xvi from comment #10)
I'm maintaining some ports and I receive notifications about new releases (not every day only if new release is available).
Comment 12 mew14930xvi 2024-07-15 10:51:53 UTC
In March the maintainer became ports@ and I don't recall seeing luakit in the reports of portscout on the mailing list.

By the way, I do not understand about maintainer-feedback.
What does it mean?
I asked at 279480 about 278925 but received no response.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279480
Comment 13 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 17:23:04 UTC
(In reply to mew14930xvi from comment #12)
Portscout check the port's MASTER_SITE. If it find a newer version on MASTER_SITE the portscout send an email to port maintainer. It doesn't send any email about change of maintainer.

"By the way, I do not understand about maintainer-feedback.
What does it mean?"
The maintainer can approve patches in bugzilla. The commiters (and maybe others too) can see a list of maintainer-approved bugs and can take and commit it.
See more here: https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-maintainer
Without maintainer approval can't commit non-trivial changes.

You approved my patch and now I can commit it. If something isn't clear please ask and I can try answer.
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-07-15 17:28:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0f752b56d84c71df59c17255a65ebeb482ee23a

commit a0f752b56d84c71df59c17255a65ebeb482ee23a
Author:     Zsolt Udvari <uzsolt@FreeBSD.org>
AuthorDate: 2024-07-15 17:26:04 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-07-15 17:27:43 +0000

    www/luakit: skip date-based versions

    Use PORTSCOUT to skip date-based (2017.*) versions.

    PR:             280272
    Approved by:    mew14930xvi <mew14930xvi@inbox.lv>

 www/luakit/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 15 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 17:30:42 UTC
Committed, thanks!
Comment 16 mew14930xvi 2024-07-15 17:42:41 UTC
I don't understand what feedback means.
The difference between + and -.
Is maintainer feedback relevant for timeouts?
In other words, can timeouts be avoided simply by commenting?

As for the mailing list, it is about this.
https://lists.freebsd.org/archives/freebsd-ports/2024-July/006384.html
Comment 17 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 18:01:35 UTC
(In reply to mew14930xvi from comment #16)
+: approved, -: rejected :)

The timeout exists, two week. And yes, the comment (from maintainer) is a feedback and reset the timeout. The comment can be a question, correction, etc.

About email message: you'll receive similar email (to your email) when a new version released. These ports are unmaintained so the email sent to everyone.
Comment 18 mew14930xvi 2024-07-15 18:33:48 UTC
Thank you.
As an excuse
In my country, +,- is used in an arithmetic sense and is not found in such a selection.
Comment 19 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 18:39:33 UTC
(In reply to mew14930xvi from comment #18)
Yes, we use + and - as arithmetic operations too and signs. In everyday life we use "positive" as "good" and "negative" as "bad".
I'm glad I could help.
Comment 20 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-15 18:43:53 UTC
(In reply to Zsolt Udvari from comment #19)
And maybe in American films (especially fighter jets, war,...) the soldiers, agents say "positive" (means "yes"), "negative" (means "no").