Bug 280350 - security/py-greenbone-feed-sync: missing dependency: devel/py-shtab
Summary: security/py-greenbone-feed-sync: missing dependency: devel/py-shtab
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-18 16:06 UTC by Trond Endrestøl
Modified: 2024-09-09 21:29 UTC (History)
1 user (show)

See Also:

Attachments
Patch for security/py-greenbone-feed-sync/Makefile adding ${PYTHON_PKGNAMEPREFIX}shtab>0:devel/py-shtab@${PY_FLAVOR} (598 bytes, patch)
2024-07-18 16:07 UTC, Trond Endrestøl 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2024-07-18 16:06:22 UTC 
Without devel/py-shtab installed, greenbone-feed-sync will complain about

ImportError: No module named 'shtab'

and obviously refuse to do anything.
Comment 1 Trond Endrestøl 2024-07-18 16:07:37 UTC 
Created attachment 252147 [details]
Patch for security/py-greenbone-feed-sync/Makefile adding ${PYTHON_PKGNAMEPREFIX}shtab>0:devel/py-shtab@${PY_FLAVOR}
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-07-18 16:56:01 UTC 
Assign to the maintainer.

(In reply to Trond Endrestøl from comment #1)

No, it should be ${PYTHON_PKGNAMEPREFIX}shtab>=1.6.5:devel/py-shtab@${PY_FLAVOR}

Furthermore, the original Makefile should be fixed as well.

from pyproject.toml [1]:
rich = ">=13.2.0"
tomli = { version = ">=2.0.1", python = "<3.11" }
shtab = ">=1.6.5"

[1] https://github.com/greenbone/greenbone-feed-sync/blob/v24.3.0/pyproject.toml#L30-L32
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-09 21:28:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3775b549e998abd869deddc0be80c05f0ebf9222

commit 3775b549e998abd869deddc0be80c05f0ebf9222
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2024-09-09 21:25:50 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2024-09-09 21:28:02 +0000

    security/py-greenbone-feed-sync: Add missing dependency

    - Improve RUN_DEPENDS
    - Bump PORTREVISION
    PR:             280350
    Reported by:    Trond Endrestøl <Trond.Endrestol __at__ ximalas.info>

 security/py-greenbone-feed-sync/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 4 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-09-09 21:29:00 UTC 
Committed thanks!