Created attachment 252181 [details] git patch Hi. I have updated pmd to version 7.3.0 and propose to take maintainership (see git patch). Poudriere runs fine for the latest three releases (13.3, 14.0, and 14.1).
Why "%%DATADIR%%-%%PORTVERSION%%" instead of "%%DATADIR%%"? Look like bin/pmd require bash for run: local script_real_loc=${BASH_SOURCE[0]:-${(%):-%x}}
Created attachment 252182 [details] git patch Thanks for the quick reply. You are right, it should be "%%DATADIR%% and not "%%DATADIR%%-%%PORTVERSION%% - fixed. bin/pmd requires BASH - yes, silly me - added RUN_DEPENDS clause Hopefully now all is well :-)
Created attachment 252183 [details] git patch portfmt, portclippy, and portlint - all clear poudriere - ok for 13.3, 14.0 and 14.1
1. MASTER_SITES= https://github.com/pmd/pmd/releases/download/pmd_releases%2F7.3.0/ Maybe this work too: MASTER_SITES= https://github.com/${PORTNAME}/${PORTNAME}/releases/download/${PORTNAME}_releases/${DISTVERSION}/ Or even without MASTER_SITES and DISTNAME, but this: DISTVERSIONPREFIX=dist- DISTVERSIONSUFFIX=-bin USE_GITHUB=yes 2. Install *.jar files in /usr/local/share/java/${PORTNAME}: DATADIR= ${JAVASHAREDIR}/${PORTNAME} ${INSTALL_DATA} ${WRKSRC}/lib/* ${STAGEDIR}${DATADIR} Like was in old Makefile.
If you don't succeed, I'll try to do it tomorrow.
(In reply to Vladimir Druzenko from comment #5) Thanks for the quick reply :-) I can get it working with MASTER_SITES, but not with the 2nd option. What I am thinking about is the lib/* issue, because there are other sub-directories... I will move the files as you suggested, but will make sure that the program is working properly, and that it can find the files in the sub-directories... Will report on this ASAP :-)
Created attachment 252184 [details] git patch Again thanks for the quick comments. Here: - MASTER_SITES as suggested - lib/*.jar like in old Makefile - tested pmd - it is working fine after the changes - portlint, etc - all OK
My suggestion: do-install: ${RM} ${WRKSRC}/bin/pmd.bat cd ${WRKSRC} && ${COPYTREE_SHARE} 'bin conf sbom' ${STAGEDIR}${DATADIR} ${RLN} ${STAGEDIR}${DATADIR}/bin/pmd ${STAGEDIR}${PREFIX}/bin/pmd ${INSTALL_DATA} ${WRKSRC}/lib/* ${STAGEDIR}${DATADIR}
Created attachment 252197 [details] v2 Check my version of the patch.
Created attachment 252198 [details] v3
Created attachment 252213 [details] git patch (In reply to Vladimir Druzenko from comment #10) Hi. I had a look at your changes - looks really nice and I've learned lots of new stuff - thanks! I also propose to have a NO_ARCH=yes as this is Java stuff...
(In reply to gatekeeper from comment #11) NO_ARCH=yes is good idea. BTW, it you use Discord you can connect to official FreeBSD Discord server: https://discord.gg/freebsd
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=df0a4276fc4e9741ca73772519bbea2349441da9 commit df0a4276fc4e9741ca73772519bbea2349441da9 Author: gatekeeper <tiago.gasiba@gmail.com> AuthorDate: 2024-07-21 22:47:12 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-21 22:47:12 +0000 devel/pmd: update 6.53.0 → 7.3.0 and take maintainership Migration from 6.x to 7.x: https://docs.pmd-code.org/pmd-doc-7.0.0/pmd_userdocs_migrating_to_pmd7.html Chagelogs: https://github.com/pmd/pmd/releases/tag/pmd_releases/6.54.0 https://github.com/pmd/pmd/releases/tag/pmd_releases/6.55.0 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.0.0-rc1 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.0.0-rc2 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.0.0-rc3 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.0.0-rc4 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.0.0 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.1.0 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.2.0 https://github.com/pmd/pmd/releases/tag/pmd_releases/7.3.0 PR: 280379 devel/pmd/Makefile | 27 +++++---- devel/pmd/distinfo | 6 +- devel/pmd/files/patch-bin_pmd (new) | 79 ++++++++++++++++++++++++ devel/pmd/pkg-plist | 117 ++++++++++++++++++++++++------------ 4 files changed, 177 insertions(+), 52 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=eea1b3a6cc685a34c22954cfc265c5e8990fc76f commit eea1b3a6cc685a34c22954cfc265c5e8990fc76f Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-07-21 23:02:06 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-21 23:02:06 +0000 devel/pmd: replace PORTVERSION → DISTVERSION PR: 280379 devel/pmd/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=39f9b2e1ba93281c5ca5a1d378be5a8a1279cdf1 commit 39f9b2e1ba93281c5ca5a1d378be5a8a1279cdf1 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-07-23 13:03:35 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-23 13:04:00 +0000 devel/pmd: use ETCDIR PR: 280379 devel/pmd/Makefile | 6 +++--- devel/pmd/pkg-plist | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=eb893893fa1836b271c539b428cca8575622de9a commit eb893893fa1836b271c539b428cca8575622de9a Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-07-24 12:32:25 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-07-24 12:32:25 +0000 devel/pmd: one more use ETCDIR PR: 280379 devel/pmd/Makefile | 3 ++- devel/pmd/files/patch-bin_pmd | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-)