Bug 280397 - finance/gnucash: Port defines conflicing C++ standards
Summary: finance/gnucash: Port defines conflicing C++ standards
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-21 20:59 UTC by Daniel Engberg
Modified: 2024-07-22 16:12 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-07-21 20:59:30 UTC 
Port defines c++11 but builds using c++17

https://cgit.freebsd.org/ports/tree/finance/gnucash/Makefile#n26
https://cgit.freebsd.org/ports/tree/finance/gnucash/Makefile#n30
https://github.com/Gnucash/gnucash/blob/5.8/CMakeLists.txt#L607

Update USES= compiler and removing USE_CXXSTD should fix the issue
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2024-07-22 06:51:52 UTC 
Hi,

Thanks for reporting.

I'll see if the discrepancy can be fixed.

Although I understand USES=compiler requirement as a minimum, so the discrepancy there is not fatal, but I agree, better be aligned!
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-07-22 16:11:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36dc1885e8fcb7a3d1f0938bbcab35b9bb0eebf6

commit 36dc1885e8fcb7a3d1f0938bbcab35b9bb0eebf6
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-07-22 16:10:34 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-07-22 16:10:34 +0000

    finance/gnucash: Define correct C++ standard for this port

    PR:             280397

 finance/gnucash/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2024-07-22 16:12:36 UTC 
C++ standards definitions fixed.

Thanks again for reporting!