Bug 280604 - games/assaultcube: Mark NOT_FOR_ARCH i386
Summary: games/assaultcube: Mark NOT_FOR_ARCH i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-04 03:22 UTC by Kevin Zheng
Modified: 2024-08-13 11:57 UTC (History)
1 user (show)

See Also:
vvd: merge-quarterly+


Attachments
Patch (1.04 KB, patch)
2024-08-04 03:22 UTC, Kevin Zheng
no flags Details | Diff
Fix build on i386 (tested build on 14.1 and 13.3) + small improvements of the port (3.05 KB, patch)
2024-08-05 21:23 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2024-08-04 03:22:57 UTC
Created attachment 252490 [details]
Patch

The build was working using clang from FreeBSD 13, but after a change in 14 the build broke.

I attempted to fix this in #272049, but the build is still failing in the bundled enet. Right now I don't have a machine to test with and doubt that anyone is running this port on i386. If anyone is able to fix this and test it, a patch is welcome.

For the time being though, I want to stop receiving pkg-fallout mail about this and so for now, mark NOT_FOR_ARCH i386.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-05 11:04:06 UTC
After remove LDFLAGS_i386+=--no-check-dynamic-relocations it build fine in poudriere 14.1 i386.
Comment 2 Kevin Zheng 2024-08-05 17:14:27 UTC
That's strange, I added that in an attempt to fix the issue. If that build is working, could you please go ahead and commit that fix? Let's see if it keeps breaking.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-05 21:23:16 UTC
Created attachment 252527 [details]
Fix build on i386 (tested build on 14.1 and 13.3) + small improvements of the port

Check, plz, other small changes.
If you agree, I'll commit as soon as I read message from you.
Comment 4 Kevin Zheng 2024-08-06 00:05:38 UTC
Comment on attachment 252527 [details]
Fix build on i386 (tested build on 14.1 and 13.3) + small improvements of the port

Approved, thanks for the help.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-08-06 01:20:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0ceefe288a8bcdee752666493a5720c532c7b0a4

commit 0ceefe288a8bcdee752666493a5720c532c7b0a4
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-08-06 01:13:55 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-06 01:13:55 +0000

    games/assaultcube: fix build on i386 and minor port improvements

    PR:             280604
    Approved by:    Kevin Zheng <kevinz5000@gmail.com> (maintainer)

 games/assaultcube/Makefile | 26 ++++++++++----------------
 games/assaultcube/distinfo |  6 +++---
 2 files changed, 13 insertions(+), 19 deletions(-)
Comment 6 Kevin Zheng 2024-08-13 01:50:54 UTC
Unfortunately it looks like the build is still failing on 140i386-quarterly and 13i386-quarterly. I've linked build logs below:

https://pkg-status.freebsd.org/beefy13/data/133i386-quarterly/d032848c5848/logs/assaultcube-1.3.0.2.log

https://pkg-status.freebsd.org/beefy19/data/140i386-quarterly/d032848c5848/logs/assaultcube-1.3.0.2.log
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-13 11:51:25 UTC
(In reply to Kevin Zheng from comment #6)
I'll MFH this commit.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-08-13 11:57:16 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3c356febe33d5ac3883cd8834f089f5514994723

commit 3c356febe33d5ac3883cd8834f089f5514994723
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-08-06 01:13:55 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-13 11:56:27 +0000

    games/assaultcube: fix build on i386 and minor port improvements

    PR:             280604
    Approved by:    Kevin Zheng <kevinz5000@gmail.com> (maintainer)

    (cherry picked from commit 0ceefe288a8bcdee752666493a5720c532c7b0a4)

 games/assaultcube/Makefile | 26 ++++++++++----------------
 games/assaultcube/distinfo |  6 +++---
 2 files changed, 13 insertions(+), 19 deletions(-)