Bug 280690 - security/sshguard daemon -l option
Summary: security/sshguard daemon -l option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-08 17:13 UTC by heas
Modified: 2025-01-27 05:57 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (kevinz5000)


Attachments
Patch (1.35 KB, patch)
2025-01-01 21:18 UTC, Kevin Zheng
kevinz5000: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description heas 2024-08-08 17:13:38 UTC
security/sshguard rc script uses /usr/sbin/daemon.  In some cases, errors do not appear to be logged anywhere when the start-up fails.  Suggest adding "-l daemon" option to increase the probability of syslogging those startup failures.
Comment 1 Kevin Zheng 2024-08-08 17:59:33 UTC
Thanks. Just curious, what kind of startup failures are you running into? This would also help me double check that a rewritten script logs correctly.
Comment 2 heas 2024-08-08 18:23:16 UTC
I did not have BACKEND set in the configuration, which did not log anywhere that I found.  After that, the whitelist file was missing (server migration), which did log to syslog.

I have not yet tried to repeat the missing configuration with daemon -l.
Comment 3 Kevin Zheng 2025-01-01 21:18:25 UTC
Created attachment 256323 [details]
Patch

Thank you for your report. Please find a patch that corrects this issue.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-27 05:56:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d8e707bfd7c0a12041b1bae18439ef9c9f264744

commit d8e707bfd7c0a12041b1bae18439ef9c9f264744
Author:     Kevin Zheng <kevinz5000@gmail.com>
AuthorDate: 2025-01-27 05:53:36 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2025-01-27 05:53:36 +0000

    security/sshguard: log under 'auth' to ensure that startup errors are logged.

    PR:             ports/280690

 security/sshguard/Makefile          | 2 +-
 security/sshguard/files/sshguard.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)