Bug 280755 - sysutils/multitail update to 7.1.5
Summary: sysutils/multitail update to 7.1.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Beat Gaetzi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-11 17:09 UTC by László Károlyi
Modified: 2024-09-25 18:27 UTC (History)
2 users (show)

See Also:
beat: maintainer-feedback+


Attachments
Update to 7.1.4a (5.43 KB, patch)
2024-08-11 17:09 UTC, László Károlyi
no flags Details | Diff
Update to 7.1.4a, w/o the duplicate 'cmake' in USES (5.43 KB, patch)
2024-08-11 17:11 UTC, László Károlyi
no flags Details | Diff
Update to 7.1.5 (5.42 KB, patch)
2024-08-13 11:00 UTC, László Károlyi
no flags Details | Diff
Portlint errors corrected patch for 7.1.5 (5.42 KB, patch)
2024-08-13 11:06 UTC, László Károlyi
no flags Details | Diff
"Unwronged" patch to 7.1.5 (5.06 KB, patch)
2024-08-16 15:04 UTC, László Károlyi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description László Károlyi 2024-08-11 17:09:05 UTC
Created attachment 252691 [details]
Update to 7.1.4a

Hello,

I can gladly report that I managed to get a patch through multitail that contains all the FreeBSD-specific changes, plus uwsgi & dovecot log highlighting (the latter of which is actually added back):

https://github.com/folkertvanheusden/multitail/pull/40

I took the liberty and made the necessary changes in ports, attached you'll find the patch to make multitail compile with the newest version.

7.x will need libgnuregex as a dependency since the '?)' (non-greedy) operator isn't supported by FreeBSD's libregex.

I request a timely merge & update.

Cheers,
László
Comment 1 László Károlyi 2024-08-11 17:11:28 UTC
Created attachment 252693 [details]
Update to 7.1.4a, w/o the duplicate 'cmake' in USES

Removed the duplicate cmake from USES, added by mistake before.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-11 21:13:16 UTC
You replaced tabs with spaces - this is wrong.
Comment 3 László Károlyi 2024-08-13 11:00:44 UTC
Created attachment 252727 [details]
Update to 7.1.5

7.1.5 is out, here's the patch for it.
Comment 4 László Károlyi 2024-08-13 11:06:02 UTC
Created attachment 252728 [details]
Portlint errors corrected patch for 7.1.5

Used portlint to place WRKSRC and LIB_DEPENDS to their own section, whatever that means.
Comment 5 Beat Gaetzi freebsd_committer freebsd_triage 2024-08-13 11:16:22 UTC
Thank you very much for the patch, looks good to me. Some small details:
- You can remove PORTREVISION when you update to a new version
- You replaced all the tabs with spaces

Would it be possible to fix this? And would you like to take over the maintainership of this port as I haven't used multitail in years.
Comment 6 László Károlyi 2024-08-13 11:18:32 UTC
(In reply to Beat Gaetzi from comment #5)
Hey,

as for the corrections: sure, I can.

I can take over the maintenance too, as long as I'll keep using this tool.

Cheers
László
Comment 7 László Károlyi 2024-08-16 15:04:30 UTC
Created attachment 252824 [details]
"Unwronged" patch to 7.1.5
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-09-25 17:29:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=726bf485e70ed68f7b09b4ca3a24a28ceb890faf

commit 726bf485e70ed68f7b09b4ca3a24a28ceb890faf
Author:     Beat Gaetzi <beat@FreeBSD.org>
AuthorDate: 2024-09-25 17:26:49 +0000
Commit:     Beat Gaetzi <beat@FreeBSD.org>
CommitDate: 2024-09-25 17:26:49 +0000

    sysutils/multitail: Update to 7.1.5

    - Pass maintainership to submitter

    PR:             280755

 sysutils/multitail/Makefile                    | 28 ++++++++++++++------------
 sysutils/multitail/distinfo                    |  6 +++---
 sysutils/multitail/files/patch-Makefile (gone) | 25 -----------------------
 sysutils/multitail/files/patch-mt.c (gone)     | 15 --------------
 sysutils/multitail/files/patch-mt.h (gone)     | 18 -----------------
 sysutils/multitail/files/patch-term.c (gone)   | 15 --------------
 6 files changed, 18 insertions(+), 89 deletions(-)
Comment 9 Beat Gaetzi freebsd_committer freebsd_triage 2024-09-25 17:30:22 UTC
Committed, thanks!
Comment 10 László Károlyi 2024-09-25 17:45:35 UTC
Thank you!

I don't know how this maintainership thing works but will figure it out.

Out of curiosity, what do you use now, that you don't use multitail anymore? I'm still using it very actively on many servers.

lnav doesn't seem to me a real contender.
Comment 11 Beat Gaetzi freebsd_committer freebsd_triage 2024-09-25 17:53:01 UTC
(In reply to László Károlyi from comment #10)
Don't worry! :) There is the porters handbook which has very detailed information if you want to look up something: https://docs.freebsd.org/en/books/porters-handbook/ 

There is also the ports@ mailing list in case of any questions.

I just use tail(1) directly. Like:
root@myserver:/var/log # tail -f daemon.log auth.log messages
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-25 18:25:35 UTC
(In reply to Beat Gaetzi from comment #11)
> root@myserver:/var/log # tail -f daemon.log auth.log messages
Or "tail -F daemon.log auth.log messages".
Comment 13 László Károlyi 2024-09-25 18:27:33 UTC
Thanks, I knew tail from the get-go, but I needed something with highlighting, which multitail does excellently.

I was looking into lnav too, I even tried using it as a PAGER for a shorter time, but it doesn't work sometimes and I stopped using it after it got annoying.

Still have it installed, only I don't use it as a PAGER anymore.