Bug 280800 - net/libiscsi: fix build on i386
Summary: net/libiscsi: fix build on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-13 17:25 UTC by Martin Birgmeier
Modified: 2024-08-13 18:58 UTC (History)
1 user (show)

See Also:
d8zNeCFG: maintainer-feedback+
vvd: merge-quarterly+

Attachments
patch to lib/socket.c (replaces the existing file) (528 bytes, text/plain)
2024-08-13 17:25 UTC, Martin Birgmeier 		no flags Details
patch to utils/discard.c (448 bytes, text/plain)
2024-08-13 17:25 UTC, Martin Birgmeier 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2024-08-13 17:25:19 UTC 
Created attachment 252738 [details]
patch to lib/socket.c (replaces the existing file)

Please place the attached two patches into net/libiscsi/files to fix the port on i386.

Looking at the code, which does not seem to be very type-clean, it might be better to just use ONLY_FOR_ARCHS=amd64 instead.

-- Martin
Comment 1 Martin Birgmeier 2024-08-13 17:25:56 UTC 
Created attachment 252739 [details]
patch to utils/discard.c
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-13 18:09:43 UTC 
After you create patches and copied to net/libiscsi/files/ do steps:
1. cd /usr/ports/net/libiscsi && make patch
2. make makepatch
3. check patches in net/libiscsi/files/

I refresh patches.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-13 18:26:01 UTC 
Also post patches to upstream please.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-13 18:36:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2056579a4bfc05bf601d9d943a025da8fbb2552e

commit 2056579a4bfc05bf601d9d943a025da8fbb2552e
Author:     Martin Birgmeier <d8zNeCFG@aon.at>
AuthorDate: 2024-08-13 18:31:59 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-13 18:31:59 +0000

    net/libiscsi: fix build on i386

    While here refresh patches with "make makepatch".

    PR:     280800
    MFH:    2024Q3

 net/libiscsi/files/patch-configure.ac                |  6 +++---
 net/libiscsi/files/patch-lib_socket.c                | 15 ++++++++++++---
 net/libiscsi/files/patch-utils_iscsi-discard.c (new) | 14 ++++++++++++++
 3 files changed, 29 insertions(+), 6 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-08-13 18:54:58 UTC 
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=372f92b8f59ee61d1f9b1bf0d1801b5b6d6fd276

commit 372f92b8f59ee61d1f9b1bf0d1801b5b6d6fd276
Author:     Martin Birgmeier <d8zNeCFG@aon.at>
AuthorDate: 2024-08-13 18:31:59 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-13 18:42:18 +0000

    net/libiscsi: fix build on i386

    While here refresh patches with "make makepatch".

    PR:     280800
    MFH:    2024Q3
    (cherry picked from commit 2056579a4bfc05bf601d9d943a025da8fbb2552e)

 net/libiscsi/files/patch-configure.ac                |  6 +++---
 net/libiscsi/files/patch-lib_socket.c                | 15 ++++++++++++---
 net/libiscsi/files/patch-utils_iscsi-discard.c (new) | 14 ++++++++++++++
 3 files changed, 29 insertions(+), 6 deletions(-)
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-13 18:58:25 UTC 
Thanks.