Bug 280861 - net/samba419: Update to 4.19.8
Summary: net/samba419: Update to 4.19.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL: https://www.samba.org/samba/history/s...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-16 12:18 UTC by Yasuhiro Kimura
Modified: 2024-09-09 16:45 UTC (History)
4 users (show)

See Also:
0mp: maintainer-feedback+

Attachments
Patch file (2.02 KB, patch)
2024-08-16 12:18 UTC, Yasuhiro Kimura 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2024-08-16 12:18:30 UTC 
Created attachment 252820 [details]
Patch file

Update to 4.19.8.

ReleaseNotes:   https://www.samba.org/samba/history/samba-4.19.8.html
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-16 12:28:32 UTC 
Thanks for the patch!

I've taken a look at the release notes and it seems like there are no changes in the dependencies.

Interestingly, upstream provides now --vendor-name and --vendor-patch-revision which we should set via CONFIGURE_ARGS in some subsequent commit after this update is committed.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-16 12:35:45 UTC 
Approved by: samba (0mp)

Let's wait for Mikaël, Timur, and Xavier until 20.08 before committing though. They might have some feedback.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2024-08-16 14:13:57 UTC 
lgtm, yasu@ do you want to be part of the samba team?
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2024-08-17 00:35:43 UTC 
(In reply to Mikael Urankar from comment #3)

Thanks for invitation. I'd like to join samba team. Please let me know if there is something I need to do with it.

Regards
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-19 10:12:32 UTC 
(In reply to Yasuhiro Kimura from comment #4)
I've added you to the wiki page and spoke to postmaster@.
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-19 10:56:40 UTC 
(In reply to Mateusz Piotrowski from comment #5)
Welcome to the team ;)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-09-09 16:45:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a2b8d2797fc47641ce156a0a657234cd1fb86f5

commit 5a2b8d2797fc47641ce156a0a657234cd1fb86f5
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2024-08-16 12:14:52 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-09-09 16:44:37 +0000

    net/samba419: Update to 4.19.8

    Changelog:      https://www.samba.org/samba/history/samba-4.19.8.html

    PR:             280861
    Approved by:    samba (mikael, yasu, 0mp)

 net/samba419/Makefile         | 2 +-
 net/samba419/distinfo         | 6 +++---
 net/samba419/pkg-plist.python | 1 +
 3 files changed, 5 insertions(+), 4 deletions(-)
Comment 8 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-09-09 16:45:56 UTC 
The patch landed! Thanks!