Bug 280873 - adduser.conf(8) references Zflag, but adduser script looks for Zcreate
Summary: adduser.conf(8) references Zflag, but adduser script looks for Zcreate
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dag-Erling Smørgrav
URL: https://reviews.freebsd.org/D46316
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-16 22:35 UTC by Rick Adams
Modified: 2024-08-21 17:16 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Adams 2024-08-16 22:35:15 UTC 
adduser.conf(8) in FreeBSD 14.1 says:
   Zflag          Do not attempt to create ZFS home dataset.

but /usr/sbin/adduser is checking for Zcreate:
   if [ "${Zcreate}" = "yes" ]; then

Change man page to reference Zcreate instead of Zflag
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-08-19 08:30:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9ff2ebd92891b6953bbe44c6d6a6d8bc31f5139f

commit 9ff2ebd92891b6953bbe44c6d6a6d8bc31f5139f
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2024-08-19 08:30:01 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2024-08-19 08:30:11 +0000

    adduser: Better document ZFS dataset creation.

    MFC after:      3 days
    PR:             280873
    Reviewed by:    bcr
    Differential Revision:  https://reviews.freebsd.org/D46316

 usr.sbin/adduser/adduser.conf.5 | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-08-21 10:30:28 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=8398c81b7c28ea315cb98405accb701502e3636a

commit 8398c81b7c28ea315cb98405accb701502e3636a
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2024-08-19 08:30:01 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2024-08-21 10:29:26 +0000

    adduser: Better document ZFS dataset creation.

    MFC after:      3 days
    PR:             280873
    Reviewed by:    bcr
    Differential Revision:  https://reviews.freebsd.org/D46316

    (cherry picked from commit 9ff2ebd92891b6953bbe44c6d6a6d8bc31f5139f)

 usr.sbin/adduser/adduser.conf.5 | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-21 10:32:29 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=90a5cd466b84b72af539a560d8e3bf7b7e408e30

commit 90a5cd466b84b72af539a560d8e3bf7b7e408e30
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2024-08-19 08:30:01 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2024-08-21 10:31:06 +0000

    adduser: Better document ZFS dataset creation.

    MFC after:      3 days
    PR:             280873
    Reviewed by:    bcr
    Differential Revision:  https://reviews.freebsd.org/D46316

    (cherry picked from commit 9ff2ebd92891b6953bbe44c6d6a6d8bc31f5139f)

 usr.sbin/adduser/adduser.conf.5 | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-21 17:15:21 UTC 
A commit in branch releng/13.4 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=eb7bf0d071916c2c11bc3f9810861998d7d070a6

commit eb7bf0d071916c2c11bc3f9810861998d7d070a6
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2024-08-19 08:30:01 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2024-08-21 17:13:33 +0000

    adduser: Better document ZFS dataset creation.

    MFC after:      3 days
    PR:             280873
    Reviewed by:    bcr
    Differential Revision:  https://reviews.freebsd.org/D46316
    Approved by:    re (cperciva)

    (cherry picked from commit 9ff2ebd92891b6953bbe44c6d6a6d8bc31f5139f)
    (cherry picked from commit 8398c81b7c28ea315cb98405accb701502e3636a)

 usr.sbin/adduser/adduser.conf.5 | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)