Bug 280891 - [new port] emulators/es-de: frontend for browsing and launching games from your multi-platform collection
Summary: [new port] emulators/es-de: frontend for browsing and launching games from yo...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://es-de.org
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-17 21:20 UTC by Stefan Schlosser
Modified: 2024-08-22 21:04 UTC (History)
1 user (show)

See Also:


Attachments
new port emulators/es-de (141.11 KB, patch)
2024-08-17 21:20 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff
new port emulators/es-de (142.19 KB, patch)
2024-08-18 11:09 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff
new port emulators/es-de (143.47 KB, patch)
2024-08-18 20:07 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff
new port emulators/es-de (141.90 KB, patch)
2024-08-22 17:25 UTC, Stefan Schlosser
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schlosser 2024-08-17 21:20:16 UTC
Created attachment 252858 [details]
new port emulators/es-de

ES-DE (formerly known as EmulationStation Desktop Edition) is a frontend for
browsing and launching games from your multi-platform collection. It comes
preconfigured for use with a large selection of emulators, game engines, game
managers and gaming services. It can also run locally installed games and
applications. It's fully customizable, so you can easily expand it with support
for additional systems and applications.

It features a modern and attractive user interface, full controller navigation
support, supports over 150 different game systems, highly customizable setup, a
built-in scraper for downloading game info and game media, full theme support
with lots of high-quality themes.

https://es-de.org
Comment 1 Stefan Schlosser 2024-08-18 11:09:53 UTC
Created attachment 252874 [details]
new port emulators/es-de

There's a problem with setting the path to the executable on FreeBSD. I opened an issue and provided a MR upstream: https://gitlab.com/es-de/emulationstation-de/-/issues/1819

I added the prelimenary patch to the port.
Comment 2 Stefan Schlosser 2024-08-18 20:07:09 UTC
Created attachment 252899 [details]
new port emulators/es-de

ES-DE calls incorrect reboot and poweroff commands on FreeBSD. I opened an issue and MR upstream, https://gitlab.com/es-de/emulationstation-de/-/issues/1820, and added the patch to the port.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-22 13:14:38 UTC
(In reply to Stefan Schlosser from comment #2)
If patch already in upstream repo then better use this instead of local patches in files/patch-*:
PATCH_SITES=    https://gitlab.com/${PORTNAME}/${GL_PROJECT}/-/commit/
# Use getPathToBinary(argv[0]) fallback in setExePath
# https://gitlab.com/es-de/emulationstation-de/-/issues/1819
PATCHFILES+=    d20b9569b73372d669745e86e805cdbea4aa1ad5.patch:-p1
# Fix runRebootCommand() and runPoweroffCommand()
# https://gitlab.com/es-de/emulationstation-de/-/issues/1820
PATCHFILES+=    6deedc22fadbd5e2a10eebece4e4d1e306f845e5.patch:-p1

Also you have several other patches with FreeBSD support - are they upstreamed already?
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-22 13:15:58 UTC
(In reply to Vladimir Druzenko from comment #3)
Run "make makesum" required after this change.
Comment 5 Stefan Schlosser 2024-08-22 17:25:20 UTC
Created attachment 253023 [details]
new port emulators/es-de

Thanks for your recommendations. I changed the port as you requested. Unfortunately, the manpage patch doesn't apply cleanly, so I had to leave it in as a separate patch. But upstream has committed all my four patches, so we can get rid of them with the next version update.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-22 21:03:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=10398afad0044dba67be17a6a87605ff63708781

commit 10398afad0044dba67be17a6a87605ff63708781
Author:     Stefan Schlosser <bsdcode@disroot.org>
AuthorDate: 2024-08-22 20:55:24 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-22 21:02:02 +0000

    emulators/es-de: New Port: frontend for browsing and launching games from your multi-platform collection

    ES-DE (formerly known as EmulationStation Desktop Edition) is a frontend
    for browsing and launching games from your multi-platform collection. It
    comes preconfigured for use with a large selection of emulators, game
    engines, game managers and gaming services. It can also run locally
    installed games and applications. It's fully customizable, so you can
    easily expand it with support for additional systems and applications.

    It features a modern and attractive user interface, full controller
    navigation support, supports over 150 different game systems, highly
    customizable setup, a built-in scraper for downloading game info and
    game media, full theme support with lots of high-quality themes.

    https://es-de.org
    https://gitlab.com/es-de/emulationstation-de

    PR:     280891

 emulators/Makefile                                 |    1 +
 emulators/es-de/Makefile (new)                     |   56 +
 emulators/es-de/distinfo (new)                     |    9 +
 emulators/es-de/files/patch-CMakeLists.txt (new)   |   83 +
 .../es-de/files/patch-es-app_CMakeLists.txt (new)  |   13 +
 .../files/patch-external_CMakeLists.txt (new)      |   23 +
 emulators/es-de/pkg-descr (new)                    |   11 +
 emulators/es-de/pkg-message (new)                  |   13 +
 emulators/es-de/pkg-plist (new)                    | 2310 ++++++++++++++++++++
 9 files changed, 2519 insertions(+)
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-22 21:04:00 UTC
Thanks.