Bug 280993 - [NEW-PORT] net-mgmt/netbox-agent: Netbox Agent
Summary: [NEW-PORT] net-mgmt/netbox-agent: Netbox Agent
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-22 10:32 UTC by Xavier Beaudouin
Modified: 2024-08-22 16:12 UTC (History)
2 users (show)

See Also:

Attachments
git format-patch for netbox-agent (3.28 KB, patch)
2024-08-22 10:32 UTC, Xavier Beaudouin 		no flags Details | Diff
git format-patch for netbox-agent (3.31 KB, application/mbox)
2024-08-22 12:32 UTC, Xavier Beaudouin 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Beaudouin 2024-08-22 10:32:35 UTC 
Created attachment 253010 [details]
git format-patch for netbox-agent

This port is a port for Netbox Agent, adapted for FreeBSD (the original code runs only on Linux).

It permits to push hardware information into netbox like memory, harddisk, ipmi information like power supplies, motherboard serial numbers etc...

Has been tested on poudriere with 14.0 and 14.1, portfmt used to check the Makefile.

Kind regards
PS: bugzilla always think the git format-patch is a mbox... as usual.
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-22 10:40:17 UTC 
Hey! Could you run portclippy on the patch? It looks like the order of some variables is off.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-22 10:46:29 UTC 
Also, since this is basically version 0.7.2 with some unreleased upstream patches and a bunch of FreeBSD-specific patches applied, I think it would be a good idea to do the following:

DISTVERSIONPREFIX=v
DISTVERSION=0.7.2-77
DISTVERSIONSUFFIX=-g6ae055c

(cf. "Example 14. Using USE_GITHUB to Access a Commit Between Two Versions", Porter's Handbook).

You won't need to specify "GH_TAGNAME=	6ae055c" then and also it would give the users a better idea what this version actually is.
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-22 10:47:15 UTC 
Also, I do not understand the comment "# PyPi sdist do not have tests". What does it mean?
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-22 10:50:39 UTC 
The last thing would be the COMMENT. Something more descriptive would be better. Maybe even: 

COMMENT=Agent for the NetBox network automation
Comment 5 Xavier Beaudouin 2024-08-22 11:38:23 UTC 
(In reply to Mateusz Piotrowski from comment #3)
This is a commit I forgot to remove. Sorry..
Comment 6 Xavier Beaudouin 2024-08-22 12:32:28 UTC 
Created attachment 253013 [details]
git format-patch for netbox-agent

This is updated git format-patch for netbox-agent with suggested changes from Mateusz.

Kind regards
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-08-22 16:12:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=28b399b1ec5e8a830cc2e8e12abc941233e83d01

commit 28b399b1ec5e8a830cc2e8e12abc941233e83d01
Author:     Xavier Beaudouin <kiwi@oav.net>
AuthorDate: 2024-08-22 12:29:08 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-08-22 16:09:45 +0000

    net-mgmt/netbox-agent: Agent for the Netbox network automation

    PR:             280993
    Sponsored by:   Bell Tower Integration
    Sponsored by:   Klara, Inc.

 net-mgmt/Makefile                     |  1 +
 net-mgmt/netbox-agent/Makefile (new)  | 35 +++++++++++++++++++++++++++++++++++
 net-mgmt/netbox-agent/distinfo (new)  |  3 +++
 net-mgmt/netbox-agent/pkg-descr (new) |  4 ++++
 4 files changed, 43 insertions(+)
Comment 8 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-22 16:12:41 UTC 
Committed! Thanks!