Bug 281096 - net/netatalk3
Summary: net/netatalk3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
: 281097 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-08-27 18:53 UTC by sseekamp
Modified: 2024-08-27 22:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
build log from poudriere (182.43 KB, text/plain)
2024-08-27 18:53 UTC, sseekamp
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description sseekamp 2024-08-27 18:53:28 UTC
Created attachment 253130 [details]
build log from poudriere

I'm trying to build this port (first time going to 3.2.x) and having a persistent linker error.

ld: error: unable to find library -liconv
cc: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.
*** Error code 1

I'm building using Poudriere with the same configure options as previous Netatalk:
- SENDFILE
- MDNSRESPONDER

all others unchecked.

My make options:
OPTIONS_UNSET+=DOCS NLS X11 EXAMPLES CUPS
OPTIONS_SET+=LIBEDIT


any help appreciated!
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2024-08-27 18:59:05 UTC
The FreeBSD ports build cluster builds netatalk3 just fine in a clean room.  The problem seems specific to you.  Do you actually have libiconv installed and a /usr/local/lib/libiconv.so.2.6.1 and /usr/local/lib/libiconv.so?
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2024-08-27 19:01:00 UTC
*** Bug 281097 has been marked as a duplicate of this bug. ***
Comment 3 sseekamp 2024-08-27 20:06:56 UTC
Thanks Joe

I will redo my build machine to get a clean environment and give it another go.

Thank you!
Comment 4 mew14930xvi 2024-08-27 20:11:03 UTC
I can build if DBUS is enabled.

$ cat /usr/local/etc/poudriere.d/make.conf
net_netatalk3_UNSET+=   ACL KERBEROS KERBEROS5 LDAP LIBWRAP MYSQL PAM SPOTLIGHT AVAHI
net_netatalk3_SET+=     DBUS SENDFILE MDNSRESPONDER

Fails if DBUS is disabled.
net_netatalk3_UNSET+=   ACL DBUS KERBEROS KERBEROS5 LDAP LIBWRAP MYSQL PAM SPOTLIGHT AVAHI
net_netatalk3_SET+=     SENDFILE MDNSRESPONDER

ld: error: unable to find library -liconv
cc: error: linker command failed with exit code 1 (use -v to see invocation)
Comment 5 sseekamp 2024-08-27 20:12:43 UTC
Intersting - is that expected? I've always disabled most of the options as I don't use/need them.

DBUS is listed as "optional" in the upstream docs (iconv is as well for that matter)
Comment 6 Joe Marcus Clarke freebsd_committer freebsd_triage 2024-08-27 20:16:15 UTC
Thanks for the additional detail.  However, I still can't reproduce.  Moreover, libiconv is brought in regardless of DBUS.  Are you not seeing the libiconv library in /usr/local/lib in your build environment?
Comment 7 mew14930xvi 2024-08-27 20:40:31 UTC
> Are you not seeing the libiconv library in /usr/local/lib in your build environment?
no.

Adding glib20 enabled the build.

-USES=          bdb:18 cpe gettext iconv meson perl5 pkgconfig shebangfix ssl tar:xz
+USES=          bdb:18 cpe gettext iconv meson perl5 pkgconfig shebangfix ssl tar:xz gnome

+USE_GNOME=     glib20

-DBUS_USES=     gnome python
-DBUS_USE=      GNOME=glib20
+DBUS_USES=     python
Comment 8 Joe Marcus Clarke freebsd_committer freebsd_triage 2024-08-27 20:52:25 UTC
Ah-ha!  Okay.  So in the base system, iconv is backed into libc.  So this explains a lot.  I'm using the same iconv as glib20 now, so this should at least work around the problem.  Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-08-27 20:55:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b8bcf488e0d0f8ea7957538be0dc4146d178237f

commit b8bcf488e0d0f8ea7957538be0dc4146d178237f
Author:     Joe Marcus Clarke <marcus@FreeBSD.org>
AuthorDate: 2024-08-27 20:52:59 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2024-08-27 20:52:59 +0000

    net/netatalk3: Use iconv:wchar_t to fix build when DBUS is disabled

    This mirrors what glib20 uses for iconv, and will ensure that we bring
    in converters/libiconv in all cases.  Not bumping PORTREVISION as the
    dependency list doesn't change in the default case.

    PR:             281096

 net/netatalk3/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 10 sseekamp 2024-08-27 22:05:07 UTC
Excellent - I'm back in business!