As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes devel/py-rapidfuzz to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /wrkdirs/usr/ports/devel/rapidfuzz-cpp/work/rapidfuzz-cpp-3.0.5/test/distance/examples/ocr.cpp:3:28: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here 3 | std::basic_string<uint8_t> ocr_example1 = { | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Once the fix for devel/rapidfuzz-cpp is in, this port only needs a few replacements of `std::basic_string` with `std::vector`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
Created attachment 253251 [details] devel/py-rapidfuzz: fix build with libc++ 19
Thanks for the patch. Approved, please commit it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3db7d7ff7deb3be6a0ddaf7e67c56c1940f34c13 commit 3db7d7ff7deb3be6a0ddaf7e67c56c1940f34c13 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-09-01 16:06:10 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-09-02 07:46:48 +0000 devel/py-rapidfuzz: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes devel/py-rapidfuzz to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /wrkdirs/usr/ports/devel/rapidfuzz-cpp/work/rapidfuzz-cpp-3.0.5/test/distance/examples/ocr.cpp:3:28: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here 3 | std::basic_string<uint8_t> ocr_example1 = { | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Once the fix for devel/rapidfuzz-cpp is in, this port only needs a few replacements of `std::basic_string` with `std::vector`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 281194 Approved by: yuri (maintainer) MFH: 2024Q3 .../files/patch-src_rapidfuzz_utils.hpp (new) | 25 +++++++++++++++++++ .../files/patch-src_rapidfuzz_utils__cpp.hpp (new) | 29 ++++++++++++++++++++++ 2 files changed, 54 insertions(+)
A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a0693fadd620db4d20a0654b8a86fbcd2b13554e commit a0693fadd620db4d20a0654b8a86fbcd2b13554e Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-09-01 16:06:10 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-09-02 07:51:02 +0000 devel/py-rapidfuzz: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes devel/py-rapidfuzz to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /wrkdirs/usr/ports/devel/rapidfuzz-cpp/work/rapidfuzz-cpp-3.0.5/test/distance/examples/ocr.cpp:3:28: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here 3 | std::basic_string<uint8_t> ocr_example1 = { | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Once the fix for devel/rapidfuzz-cpp is in, this port only needs a few replacements of `std::basic_string` with `std::vector`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 281194 Approved by: yuri (maintainer) MFH: 2024Q3 (cherry picked from commit 3db7d7ff7deb3be6a0ddaf7e67c56c1940f34c13) .../files/patch-src_rapidfuzz_utils.hpp (new) | 25 +++++++++++++++++++ .../files/patch-src_rapidfuzz_utils__cpp.hpp (new) | 29 ++++++++++++++++++++++ 2 files changed, 54 insertions(+)