Created attachment 253385 [details] patch 2 tests fail: One test fails because of the missing test file. Another test fails because they expect one particular runtime to take < 5 secsonds which is always a wrong thing to do. Both test failures appear to be due to problems in tests themselves, and not due to problems in the project.
This is required to update the spyder port to 6.0.0
Hi Yuri, Thanks for your patch. But this time I'm a little earlier ;) I had already opened Issue #501 on August 31st [1] to address exactly this timing problem in 'test_interrupt' and to look for solutions. My suggestion to the spyder-kernels project would be that we may increase the time tolerance for FreeBSD, see also in the issue. I haven't received a reply yet, but I think I would be fine with such a patch for FreeBSD for now. Later our port can be patched again if there is a more elegant way. [1] https://github.com/spyder-ide/spyder-kernels/issues/501
(In reply to Rainer Hurling from comment #2) Hi Rainer, Thank you for the quick approval, I will commit this patch shortly. As for the timeout problem in the test, increasing the threshold wouldn't be able to help because on a very busy system the actual running time would exceed any given threshold value if the system would be busy enough. It seems that they should find a better solution for this than comparing times. Best, Yuri
(In reply to Yuri Victorovich from comment #3) Ok, but let me do the commit. My patch is also ready for some days now and almost the same as yours ;)
(In reply to Rainer Hurling from comment #4) Ok, do it. -) Yuri
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7dda6b563549e7e681e4ae86d8a06c3e7868cda9 commit 7dda6b563549e7e681e4ae86d8a06c3e7868cda9 Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2024-09-07 06:03:18 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2024-09-07 07:24:12 +0000 devel/py-spyder-kernels: Update to 3.0.0 Changelog: https://github.com/spyder-ide/spyder-kernels/blob/master/CHANGELOG.md#version-300-2024-08-29 PR: 281318 Reported by: portscout, Repology devel/py-spyder-kernels/Makefile | 14 ++++++++----- devel/py-spyder-kernels/distinfo | 6 +++--- devel/py-spyder-kernels/files/patch-setup.py | 23 ++++++++++------------ ...ls_console_tests_test__console__kernel.py (new) | 11 +++++++++++ 4 files changed, 33 insertions(+), 21 deletions(-)
(In reply to Yuri Victorovich from comment #5) Thank you again, Yuri, for your understanding. My patch was already finished, I just tested it again before committing.