Bug 281346 - irc/znc: Improve and simplify port
Summary: irc/znc: Improve and simplify port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-07 19:25 UTC by Daniel Engberg
Modified: 2024-09-24 22:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (dbaio)


Attachments
Patch for znc (3.36 KB, patch)
2024-09-07 19:25 UTC, Daniel Engberg
no flags Details | Diff
Patch for znc v2 (3.49 KB, patch)
2024-09-09 00:07 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-09-07 19:25:20 UTC
Created attachment 253409 [details]
Patch for znc

* Always build with ICU support
* Remove DEBUG menu option, use ports framework instead
* Always enable IPv6, it's 2024 and the kernel already comes with it
* Always enable Python module, it's already a hard dependency
* Do some small layout enhancements to port Makefile

This also aligns it more with other distros that packages znc

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-08 23:24:13 UTC
(In reply to Daniel Engberg from comment #0)
You forgot to remove OPTIONS_DEFAULT=OPENSSL.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-09-09 00:07:58 UTC
Created attachment 253440 [details]
Patch for znc v2

Remove stray OPENSSL definition
Adjust indent for DESC section
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-09-09 00:08:10 UTC
(In reply to Vladimir Druzenko from comment #1)
Fixed, thanks
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-09-24 22:58:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=26fb50b82a5dab65dec324b8b50f6b8e3f48195d

commit 26fb50b82a5dab65dec324b8b50f6b8e3f48195d
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-09-24 22:53:27 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-09-24 22:53:29 +0000

    irc/znc: Improve and simplify port

    * Always build with ICU support
    * Remove DEBUG menu option, use ports framework instead
    * Always enable IPv6, kernel support is always enabled
    * Always enable Python module as Python is already a hard dependency
    * Do some small layout enhancements to port Makefile

    This also aligns it more with other distros that packages znc

    PR:             281346
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

 irc/znc/Makefile  | 58 +++++++++++++++++++++++++++----------------------------
 irc/znc/pkg-plist | 22 ++++++++++-----------
 2 files changed, 39 insertions(+), 41 deletions(-)