Bug 281388 - misc/nnn Update to 5.0 and take over maintainership
Summary: misc/nnn Update to 5.0 and take over maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL: https://github.com/jarun/nnn/releases...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-09 11:21 UTC by Bartek Jasicki
Modified: 2024-12-06 20:28 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback-

Attachments
Update to 5.0 (890 bytes, patch)
2024-09-09 11:21 UTC, Bartek Jasicki 		no flags Details | Diff
Update to 5.0 second try (1.52 KB, patch)
2024-12-06 08:21 UTC, Bartek Jasicki 		no flags Details | Diff
Patch for nnn (1.12 KB, patch)
2024-12-06 19:58 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bartek Jasicki 2024-09-09 11:21:32 UTC 
Created attachment 253455 [details]
Update to 5.0

Update the port to version 5.0.

Additionally, I want to take over maintainership of the package. Two previous updates of the port were done due to the maintainer's timeout: bug #273512 and bug #272061. I was trying to contact with the maintainer before this update, unfortunately I had no answer. I'm using the port on my daily basis, so I can maintain it too. ;)

If the maintainer can read this, please, send a sign, then I will remove take over request from the patch and leave only the update of version.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-12-05 23:45:13 UTC 
Hi,

Please use upstream release archive, https://github.com/jarun/nnn/releases/download/v5.0/nnn-v5.0.tar.gz (remove USE_GITHUB etc) and use MASTER_SITES instead.
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

I would also recommend letting the framework handling stripping so pass STRIP_CMD to MAKE_ARGS

Best regards,
Daniel
Comment 2 Bartek Jasicki 2024-12-06 08:21:30 UTC 
Created attachment 255658 [details]
Update to 5.0 second try

(In reply to Daniel Engberg from comment #1)

Hello,

Thank you very much for checking it. Here is the new version of the patch, with, I think, all suggested changes. I didn't remove USE_GITHUB, etc. because they are needed for MASTER_SITES_GH macro. If something is still wrong, please tell. :)

Have a nice day,
Bartek
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2024-12-06 17:41:13 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-12-06 17:41:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=66afe3539a304907ff653c52011d3b9d227bf305

commit 66afe3539a304907ff653c52011d3b9d227bf305
Author:     Bartek Jasicki <thindil@laeran.pl.eu.org>
AuthorDate: 2024-12-06 17:39:37 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2024-12-06 17:39:37 +0000

    misc/nnn: update 4.9 -> 5.0, submitter becomes maintainer

    PR:             281388
    Reviewed:       diizzy
    Changes:        https://github.com/jarun/nnn/releases/tag/v5.0

 misc/nnn/Makefile | 9 +++++----
 misc/nnn/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 7 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-12-06 19:58:37 UTC 
Created attachment 255672 [details]
Patch for nnn

Use upstream release archive
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-12-06 19:58:55 UTC 
This is how it should look ;-)
Comment 7 Bartek Jasicki 2024-12-06 20:28:58 UTC 
(In reply to Daniel Engberg from comment #6)

Ah, thank you very much, noted. ;)
I will use it with the next release.