Bug 281588 - devel/py-pythran: switch to pep517
Summary: devel/py-pythran: switch to pep517
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-19 11:14 UTC by Max Brazhnikov
Modified: 2024-09-22 08:55 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (wen)


Attachments
patch (1.81 KB, patch)
2024-09-19 11:14 UTC, Max Brazhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Brazhnikov freebsd_committer freebsd_triage 2024-09-19 11:14:58 UTC
Created attachment 253662 [details]
patch

switch to pep517 and bump PORTREVISION to fix runtime error when building dependent ports.
Comment 1 wen 2024-09-19 13:04:36 UTC
Please go ahead !
Thanks !
Comment 2 Charlie Li freebsd_committer freebsd_triage 2024-09-20 04:12:17 UTC
This isn't correct. The specific dependency versions that upstream specified are that way for a reason: gast 0.5 and 0.6 are not compatible with each other, and using the wrong version will result in runtime errors. The correct action is to revert devel/py-gast back to 0.5, unless pythran is updated to/past the commit bumping the gast dependency.
Comment 3 wen 2024-09-20 07:20:45 UTC
(In reply to Charlie Li from comment #2)
Upstream switch to gast-0.6 now.
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2024-09-20 10:44:08 UTC
(In reply to Charlie Li from comment #2)
Charlie, in general you are absolutely right. But in this particular case I think it is safe. Upstream has switched pythran to gast-0.6 right after the release (btw, both are developed by the same author) and the only change in gast is unification across all python versions:
https://github.com/serge-sans-paille/gast/commit/5b3d851fa2dabb8deef5d17d303cc823f5ae4aca
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-09-22 08:54:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7383168a2c89c4ec9a4927efd83a24f2abb77c24

commit 7383168a2c89c4ec9a4927efd83a24f2abb77c24
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2024-09-22 08:52:05 +0000
Commit:     Max Brazhnikov <makc@FreeBSD.org>
CommitDate: 2024-09-22 08:52:05 +0000

    devel/py-pythran: convert to pep517

    and bump PORTREVISION to fix runtime error when building dependent ports.

    PR:             281588
    Appoved by:     wen@ (maintainer)

 devel/py-pythran/Makefile                           |  5 ++++-
 devel/py-pythran/files/patch-requirements.txt (new) | 10 ++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)