Created attachment 253937 [details] Patch to update nzbget to v24.3 Update the news/nzbget to v24.3. * Change the build system to cmake only * Expose the most relevant build options as port options * Configure make test to run ctest Deleted files: * files/patch-configure.ac * files/extra-disable-optimized-flags.patch See https://github.com/nzbgetcom/nzbget/releases/tag/v24.3 for software changes.
Maintainer informed via mail
maintainer timeout Here is some feedback on your patch: - we ship zlib in base, no need to make depending on it optional - if you make a dependency optional, make sure we don't actually depend on it when the option is turned off. This e.g. affects ncurses, on which this port unconditionally depends through USES=ncurses even when the option is turned off. Fix this by adding ncurses to NCURSES_USES instead of USES. - instead of a hand-rolled do-test target, set USES= cmake:testing. This will add the right code to hook up cmake test suites. - I don't see you adding openssl or gnutls to the dependencies anywhere. Make sure dependencies are added when the corresponding options are enabled. - TLS cannot be enabled as it's an option group. Please test the patch carefully with Poudriere before submitting it. Test all port options to make sure the dependencies are configured correctly. Many of these issues would have been caught quickly with proper testing. Please fix your patch and resubmit.
Created attachment 254856 [details] Patch to update nzbget to v24.3 Thanks a lot for the feedback. Apologies for the poor quality of the first patch, I'm pretty new to this hence still learning. I resubmitted a new version of the patch taking into account your comments. I carefully tested the port with poudriere with all combinations of options and it seems dependencies are now properly linked to options. cmake:testing worked perfectly and I removed my manual hook for tests. Please let me know if anything else looks improper and I'll fix. Thanks again.
Thank you for the update. Here is some more feedback: - use DISTVERSION instead of PORTVERSION if possible. - what is the effect of the TEST option? Does it affect the binaries that are built? If this option is just needed to build and run the test suite, but has otherwise no effect on the package built, remove the option and instead add the cmake flag of this option to CMAKE_TESTING_ON, which means that it'll be enabled when building for "make test". Please check and resubmit if applicable. Port looks good otherwise and I'm sure I can commit it with my next batch.
Created attachment 254860 [details] Patch to update nzbget to v24.3 Thanks for the feedback. I applied the changes, please let me know. By the way I'd be happy to be maintainer of this package if that's an option
Yeah sure why not, I'll add you as the maintainer.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5e0d1cd6403dbf3002715bb282bedd4ab734a2a3 commit 5e0d1cd6403dbf3002715bb282bedd4ab734a2a3 Author: Alexandre Levy <a13xlevy@pm.me> AuthorDate: 2024-10-01 14:00:42 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-11-06 15:14:31 +0000 news/nzbget: Upgrade to v24.3 * Change the build system to cmake only * Expose the most relevant build options as port options * Configure make test to run ctest * Assign maintainership to submitter, old maintainer is AWOL Changelog: https://github.com/nzbgetcom/nzbget/releases/tag/v24.3 PR: 281800 Approved by: alexis.praga@free.fr (maintainer timeout) news/nzbget/Makefile | 29 +++++++++++----------- news/nzbget/distinfo | 6 ++--- .../extra-disable-optimized-flags.patch (gone) | 16 ------------ news/nzbget/files/patch-configure.ac (gone) | 20 --------------- news/nzbget/pkg-plist | 3 +-- 5 files changed, 18 insertions(+), 56 deletions(-)
Thank you for your submission.