Clang 19 has become more strict about errors in member functions, which results in errors building graphics/embree: /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:56: error: no member named 'u' in 'QuadraticBezierCurve<V>' 138 | return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")"; | ~ ^ /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:77: error: no member named 'u' in 'QuadraticBezierCurve<V>' 138 | return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")"; | ~ ^ Upstream fixed this for https://github.com/RenderKit/embree/issues/486 in https://github.com/RenderKit/embree/commit/cda4cf191, so add a PATCHFILES entry for it.
Created attachment 254019 [details] graphics/embree: fix build with clang 19
Comment on attachment 254019 [details] graphics/embree: fix build with clang 19 Looks good, as always. Feel free to PATCHFILES-fix any of my other ports when it suffices, without opening a PR, thank you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7bf7810c8515f9008d6c86ca88a9838aeb886942 commit 7bf7810c8515f9008d6c86ca88a9838aeb886942 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-10-05 14:27:05 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-10-05 16:33:25 +0000 graphics/embree: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in errors building graphics/embree: /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:56: error: no member named 'u' in 'QuadraticBezierCurve<V>' 138 | return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")"; | ~ ^ /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:77: error: no member named 'u' in 'QuadraticBezierCurve<V>' 138 | return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")"; | ~ ^ Upstream fixed this for https://github.com/RenderKit/embree/issues/486 in https://github.com/RenderKit/embree/commit/cda4cf191, so add a PATCHFILES entry for it. PR: 281868 Approved by: danfe (maintainer) MFH: 2024Q3 graphics/embree/Makefile | 3 +++ graphics/embree/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)
A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=787b4f9530327fab513eaf8810bd63ace9172476 commit 787b4f9530327fab513eaf8810bd63ace9172476 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-10-05 14:27:05 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-10-05 16:35:25 +0000 graphics/embree: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in errors building graphics/embree: /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:56: error: no member named 'u' in 'QuadraticBezierCurve<V>' 138 | return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")"; | ~ ^ /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:77: error: no member named 'u' in 'QuadraticBezierCurve<V>' 138 | return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")"; | ~ ^ Upstream fixed this for https://github.com/RenderKit/embree/issues/486 in https://github.com/RenderKit/embree/commit/cda4cf191, so add a PATCHFILES entry for it. PR: 281868 Approved by: danfe (maintainer) MFH: 2024Q3 (cherry picked from commit 7bf7810c8515f9008d6c86ca88a9838aeb886942) graphics/embree/Makefile | 3 +++ graphics/embree/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)