Bug 282152 - sysutils/eza: update to 0.20.4
Summary: sysutils/eza: update to 0.20.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL: https://github.com/eza-community/eza/...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-17 06:09 UTC by Ken DEGUCHI
Modified: 2024-10-26 03:24 UTC (History)
1 user (show)

See Also:

Attachments
Update to eza-0.20.3 (71.19 KB, patch)
2024-10-17 06:09 UTC, Ken DEGUCHI 		kdeguchi: maintainer-approval+
Details | Diff
Update to eza-0.20.4 (71.27 KB, patch)
2024-10-20 02:10 UTC, Ken DEGUCHI 		kdeguchi: maintainer-approval+
Details | Diff
eza suggested improvements (68.96 KB, patch)
2024-10-20 21:39 UTC, Rodrigo Osorio 		no flags Details | Diff
Update to eza-0.20.4 (68.95 KB, patch)
2024-10-21 08:31 UTC, Ken DEGUCHI 		kdeguchi: maintainer-approval+
Details | Diff
Update to eza-0.20.5 (69.53 KB, patch)
2024-10-26 00:05 UTC, Ken DEGUCHI 		kdeguchi: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken DEGUCHI 2024-10-17 06:09:40 UTC 
Created attachment 254303 [details]
Update to eza-0.20.3

eza-0.20.3 has released. I have created a patch.

-Use CARGO_DIST_SUBDIR for crates files to reduce download waste.
Comment 1 Ken DEGUCHI 2024-10-20 02:10:27 UTC 
Created attachment 254380 [details]
Update to eza-0.20.4

eza-0.20.4 has released. I have created a patch.
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2024-10-20 21:39:15 UTC 
Created attachment 254412 [details]
eza suggested improvements

Hi,
Your patch work as expected but it wan be improved

You are currently using DIST_SUBDIR, to avoid ditfiles naming conflicts,
and added a CARGO_DIST_SUBDIR with the "../rust/crates" value to use the
regular rust disfile location and bypass the issue created by DIST_SUBDIR
addition.

I found this logic a little bit clunky and not easy to understand, may I suggest you
to do the following change (a couple of ports use the same method).

I attach to this comment a patch with another way to avoid conflicts with distfiles
without playing with the distfiles subdirs.
Comment 3 Ken DEGUCHI 2024-10-20 23:31:04 UTC 
(In reply to Rodrigo Osorio from comment #2)

I see, so you can use it that way with DISTFILES. That makes sense.

I hope you will commit the attached patch. Thanks.
Comment 4 Ken DEGUCHI 2024-10-21 08:31:39 UTC 
Created attachment 254419 [details]
Update to eza-0.20.4

Changed the method of specifying the name of the file to be downloaded in DISTFILES.
Comment 5 Ken DEGUCHI 2024-10-26 00:05:05 UTC 
Created attachment 254516 [details]
Update to eza-0.20.5

eza-0.20.5 has released. I have created a patch.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-10-26 03:22:40 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=66b0c643d90d1e0e0f6e64c1188599b985f2f3d3

commit 66b0c643d90d1e0e0f6e64c1188599b985f2f3d3
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-10-26 03:13:11 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-10-26 03:19:26 +0000

    sysutils/eza: update to 0.20.5

    Changelogs:
        https://github.com/eza-community/eza/releases/tag/v0.20.5
        https://github.com/eza-community/eza/releases/tag/v0.20.4
        https://github.com/eza-community/eza/releases/tag/v0.20.3

    Major changes:
        * Approximately a ~24% speedup for most common operations
        * Filetype, coloring for executables and folder

    PR:             282152
    Reported by:    Ken DEGUCHI <kdeguchi@sz.tokoha-u.ac.jp> (maintainer)

 sysutils/eza/Makefile        |  14 +-
 sysutils/eza/Makefile.crates |   4 +-
 sysutils/eza/distinfo        | 818 +++++++++++++++++++++----------------------
 3 files changed, 417 insertions(+), 419 deletions(-)
Comment 7 Rodrigo Osorio freebsd_committer freebsd_triage 2024-10-26 03:24:34 UTC 
Committed with minor changes to make portfmt happy, thanks