Bug 282170 - [patch] net/netatalk3: versions after 3.2.5 always build CNID MySQL backend
Summary: [patch] net/netatalk3: versions after 3.2.5 always build CNID MySQL backend
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Joe Marcus Clarke
URL: https://cgit.freebsd.org/ports/diff/n...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-18 09:36 UTC by Andrew
Modified: 2024-10-22 18:08 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Makefile_patch_for_noMYSQL (649 bytes, patch)
2024-10-18 09:36 UTC, Andrew 		andrew.hotlab: maintainer-approval? (marcus)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew 2024-10-18 09:36:35 UTC 
Created attachment 254326 [details]
Makefile_patch_for_noMYSQL

Building version 3.2.10 (2024Q4) on releng/13.4, I noticed that the CNID backend support for MySQL was compiled even if the MYSQL option was set to OFF.

The attached patch solved the issue, which I think it was introduced by this commit:
https://cgit.freebsd.org/ports/diff/net/netatalk3/Makefile?id=58493c5f3e14aec5dbe852cfcb3d84f2504eee69
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2024-10-22 18:08:29 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-22 18:08:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a71316ec3bb53952c8dad9211ec5d051f411653b

commit a71316ec3bb53952c8dad9211ec5d051f411653b
Author:     Andrew <andrew.hotlab@hotmail.com>
AuthorDate: 2024-10-22 18:06:03 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2024-10-22 18:07:50 +0000

    net/netatalk3: Prevent MySQL backend from always being built

    PR:             282170

 net/netatalk3/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)