Bug 282192 - absolute symlink in /usr/bin
Summary: absolute symlink in /usr/bin
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 15.0-CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL: https://reviews.freebsd.org/D47226
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-19 10:18 UTC by Wolfram Schneider
Modified: 2024-10-29 20:58 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfram Schneider freebsd_committer freebsd_triage 2024-10-19 10:18:32 UTC 
There are some relative symbolic links in /usr/bin, and a single one with an absolute symbolic link.

find /usr/bin/ -type l -ls | egrep -- ' -> /'
 21538        1 lrwxr-xr-x    1 root                             wheel                                  16 Dec  9  2023 /usr/bin/zstreamdump -> /usr/bin/zstream

I think that "zstreamdump" should point to "zstream" and not to "/usr/bin/zstream"

see
cddl/usr.bin/zstream/Makefile:SYMLINKS= ${BINDIR}/zstream ${BINDIR}/zstreamdump
Comment 1 Ed Maste freebsd_committer freebsd_triage 2024-10-19 23:51:14 UTC 
Yes, I agree. Will you update it?
Comment 2 Wolfram Schneider freebsd_committer freebsd_triage 2024-10-20 09:04:31 UTC 
(In reply to Ed Maste from comment #1)
zfs is an external software. I am not familiar with maintaining external software in the FreeBSD src tree, I would prefer someone else to fix the problem.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-26 12:54:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=01a5af6a98fc3935b57a5b0616521f46e916caec

commit 01a5af6a98fc3935b57a5b0616521f46e916caec
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-10-21 17:15:46 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-10-26 12:53:16 +0000

    zstream: avoid absolute symlink

    PR:             282192
    Reported by:    wosch
    Fixes:          44877c8db05b
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D47226

 cddl/usr.bin/zstream/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-29 20:37:16 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=915d84fbba276e2ceac64ff42d3baa7da51cba6a

commit 915d84fbba276e2ceac64ff42d3baa7da51cba6a
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-10-21 17:15:46 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-10-29 20:33:26 +0000

    zstream: avoid absolute symlink

    PR:             282192
    Reported by:    wosch
    Fixes:          44877c8db05b
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D47226

    (cherry picked from commit 01a5af6a98fc3935b57a5b0616521f46e916caec)

 cddl/usr.bin/zstream/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)