Bug 282336 - graphics/jp2a: Improve port
Summary: graphics/jp2a: Improve port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-26 15:21 UTC by Daniel Engberg
Modified: 2024-10-28 08:24 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
Patch for jp2a (1.50 KB, patch)
2024-10-26 15:21 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-10-26 15:21:21 UTC 
Created attachment 254535 [details]
Patch for jp2a

* Use release archive as suggested by section 5.4.3 in Porter's Handbook.
* Remove USES= autoreconf
* Use USES= localbase:ldflags
* Remove CONFIGURE_ENV and MAKE_ENV (unnecessary)
* Add --disable-assert to CONFIGURE_ARGS
* Remove USE_CSTD, builds fine without?
* Remove unncessary LDFLAGS

Compile and runtime tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist, make test)

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2024-10-28 08:24:02 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-28 08:24:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f742a28acd2b665828d83ed45b50d5ad654ea857

commit f742a28acd2b665828d83ed45b50d5ad654ea857
Author:     Emanuel Haupt <ehaupt@FreeBSD.org>
AuthorDate: 2024-10-28 08:23:31 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2024-10-28 08:23:35 +0000

    graphics/jp2a: Give the port a makeover

    Use the release archive to remove USES=autoreconf. Eliminate
    CONFIGURE_ENV, MAKE_ENV, USE_CSTD, and LDFLAGS, as they are no longer
    needed for this port. Add USES=localbase:ldflags and --disable-assert to
    CONFIGURE_ARGS.

    PR:             282336
    Reported by:    diizzy

 graphics/jp2a/Makefile | 15 +++++----------
 graphics/jp2a/distinfo |  6 +++---
 2 files changed, 8 insertions(+), 13 deletions(-)