Both "14.1-RELEASE releng/14.1-n267679-10e31f0946d8 GENERIC amd64" and "14.2-PRERELEASE stable/14-n269296-5ae76ff5138e GENERIC amd64" kernels panic at the same point during startup on a system with a Chelsio T320 NIC installed, with two 10Gbase-SR SFP+ installed. This crash appears to be triggered by something in the OPNSense 24.7 startup, but userspace doesn't appear to be doing anything unreasonable at the time.
Here's the last few lines of the message buffer before the panic: Starting device manager... acpi_wmi0: <ACPI-WMI mapping> on acpi0 acpi_wmi0: Embedded MOF found ACPI: \_SB.WMIB.WQZZ: 1 arguments were passed to a non-method ACPI object (Buffer) (20221020/nsarguments-361) acpi_wmi1: <ACPI-WMI mapping> on acpi0 acpi_wmi1: Embedded MOF found ACPI: \_SB.WMIV.WQZZ: 1 arguments were passed to a non-method ACPI object (Buffer) (20221020/nsarguments-361) acpi_wmi2: <ACPI-WMI mapping> on acpi0 acpi_wmi2: Embedded MOF found cxgbc0: <Chelsio T320, 2 ports> mem 0xd1000000-0xd1000fff,0xd1001000-0xd1001fff irq 16 at device 0.0 on pci1 cxgbc0: using MSI-X interrupts (9 vectors) cxgb0: <Port 0 10GBASE-R> on cxgbc0 Fatal trap 12: page fault while in kernel mode I am not able to reproduce the panic when booting from a FreeBSD 14.1 or FreeBSD 14.2-PRERELEASE memstick, although I have not tried an install. Here's the backtrace from the latest 14.2 PRERELEASE kernel: Fatal trap 12: page fault while in kernel mode cpuid = 2; apic id = 04 fault virtual address = 0x0 fault code = supervisor read instruction, page not present instruction pointer = 0x20:0x0 stack pointer = 0x28:0xfffffe00aab0b6f8 frame pointer = 0x28:0xfffffe00aab0b720 code segment = base rx0, limit 0xfffff, type 0x1b = DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags = interrupt enabled, resume, IOPL = 0 current process = 367 (devctl) rdi: fffff80024451000 rsi: fffffe00aab0b770 rdx: fffffe00acbb9ed8 rcx: 00000000c0306938 r8: 0000000000000000 r9: 0000000000000000 rax: 0000000000000000 rbx: fffffe00aab0b770 rbp: fffffe00aab0b720 r10: fffff8003bb06800 r11: 0000000000000800 r12: 0000000000008802 r13: fffff8003bb06810 r14: fffffe00acbb9ed8 r15: 0000000000000000 trap number = 12 panic: page fault cpuid = 2 time = 1730034648 KDB: stack backtrace: #0 0xffffffff80b8b9bd at kdb_backtrace+0x5d #1 0xffffffff80b3e101 at vpanic+0x131 #2 0xffffffff80b3dfc3 at panic+0x43 #3 0xffffffff81024a0b at trap_fatal+0x40b #4 0xffffffff81024a56 at trap_pfault+0x46 #5 0xffffffff80ffb538 at calltrap+0x8 #6 0xffffffff80d897e5 at dump_iface+0x145 #7 0xffffffff80d891a9 at rtnl_handle_ifevent+0xa9 #8 0xffffffff80c5c75f at if_attach_internal+0x3df #9 0xffffffff80c6784c at ether_ifattach+0x2c #10 0xffffffff83327b53 at cxgb_port_attach+0x1d3 #11 0xffffffff80b7abac at device_attach+0x3ac #12 0xffffffff80b7be7b at bus_generic_attach+0x4b #13 0xffffffff83326ab6 at cxgb_controller_attach+0x926 #14 0xffffffff80b7abac at device_attach+0x3ac #15 0xffffffff80b7a7e1 at device_probe_and_attach+0x41 #16 0xffffffff80818382 at pci_driver_added+0xf2 #17 0xffffffff80b78269 at devclass_driver_added+0x29 I can provide vmcore files from 14.1-RELEASE or 14.2-PRERELEASE, and am happy to test with other kernels if necessary. The information below is from a vmcore on "FreeBSD 14.2-PRERELEASE stable/14-n269296-5ae76ff5138e GENERIC amd64" In kgdb, the backtrace is slightly different, with the page fault in ifmedia_ioctl due to a null pointer in ifm->ifm_status - the ifm_status callback pointer is null. #9 0xffffffff80c6c329 in ifmedia_ioctl (ifp=0xfffff80024451000, ifr=0xfffffe00aab0b770, ifm=0xfffffe00acbb9ed8, cmd=<optimized out>) at /usr/src/sys/net/if_media.c:293 warning: Source file is more recent than executable. 293 (*ifm->ifm_status)(ifp, ifmr); (kgdb) p ifm $1 = (struct ifmedia *) 0xfffffe00acbb9ed8 (kgdb) p ifm->ifm_status $2 = (ifm_stat_cb_t) 0x0 And here's the more complete backtrace as shown in kgdb: #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:57 #1 doadump (textdump=<optimized out>) at /usr/src/sys/kern/kern_shutdown.c:405 #2 0xffffffff80b3dc97 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:523 #3 0xffffffff80b3e16e in vpanic (fmt=0xffffffff81174043 "%s", ap=ap@entry=0xfffffe00aab0b550) at /usr/src/sys/kern/kern_shutdown.c:967 #4 0xffffffff80b3dfc3 in panic (fmt=<unavailable>) at /usr/src/sys/kern/kern_shutdown.c:891 #5 0xffffffff81024a0b in trap_fatal (frame=0xfffffe00aab0b630, eva=0) at /usr/src/sys/amd64/amd64/trap.c:952 #6 0xffffffff81024a56 in trap_pfault (frame=<unavailable>, usermode=false, signo=<optimized out>, ucode=<optimized out>) at /usr/src/sys/amd64/amd64/trap.c:760 #7 <signal handler called> #8 0x0000000000000000 in ?? () #9 0xffffffff80c6c329 in ifmedia_ioctl (ifp=0xfffff80024451000, ifr=0xfffffe00aab0b770, ifm=0xfffffe00acbb9ed8, cmd=<optimized out>) at /usr/src/sys/net/if_media.c:293 #10 0xffffffff80d897e5 in get_operstate_ether (ifp=0xfffff80024451000, pstate=<optimized out>) at /usr/src/sys/netlink/route/iface.c:124 #11 get_operstate (ifp=0xfffff80024451000, pstate=<optimized out>) at /usr/src/sys/netlink/route/iface.c:181 #12 dump_iface (nw=nw@entry=0xfffffe00aab0b7e8, ifp=ifp@entry=0xfffff80024451000, hdr=hdr@entry=0xfffffe00aab0b828, if_flags_mask=if_flags_mask@entry=0) at /usr/src/sys/netlink/route/iface.c:310 #13 0xffffffff80d891a9 in rtnl_handle_ifevent (ifp=0xfffff80024451000, nlmsg_type=<optimized out>, if_flags_mask=0) at /usr/src/sys/netlink/route/iface.c:1411 #14 0xffffffff80c5c75f in if_attach_internal (ifp=ifp@entry=0xfffff80024451000, vmove=<optimized out>) at /usr/src/sys/net/if.c:957 #15 0xffffffff80c5c379 in if_attach (ifp=ifp@entry=0xfffff80024451000) at /usr/src/sys/net/if.c:772 #16 0xffffffff80c6784c in ether_ifattach (ifp=ifp@entry=0xfffff80024451000, lla=0xfffffe00aab0b770 "", lla@entry=0xfffffe00acbb9f38 "") at /usr/src/sys/net/if_ethersubr.c:1001 #17 0xffffffff83327b53 in cxgb_port_attach (dev=0xfffff80006f09100) at /usr/src/sys/dev/cxgb/cxgb_main.c:1044 #18 0xffffffff80b7abac in DEVICE_ATTACH (dev=0xfffff80006f09100) at ./device_if.h:195 #19 device_attach (dev=dev@entry=0xfffff80006f09100) at /usr/src/sys/kern/subr_bus.c:2548 #20 0xffffffff80b7be7b in device_probe_and_attach (dev=0xfffff80006f09100) at /usr/src/sys/kern/subr_bus.c:2505 #21 bus_generic_attach (dev=dev@entry=0xfffff80001b11000) at /usr/src/sys/kern/subr_bus.c:3381 #22 0xffffffff83326ab6 in cxgb_controller_attach (dev=0xfffff80001b11000) at /usr/src/sys/dev/cxgb/cxgb_main.c:644 #23 0xffffffff80b7abac in DEVICE_ATTACH (dev=0xfffff80001b11000) at ./device_if.h:195 #24 device_attach (dev=dev@entry=0xfffff80001b11000) at /usr/src/sys/kern/subr_bus.c:2548 #25 0xffffffff80b7a7e1 in device_probe_and_attach (dev=dev@entry=0xfffff80001b11000) at /usr/src/sys/kern/subr_bus.c:2505 #26 0xffffffff80818382 in pci_driver_added (dev=0xfffff80001b11100, driver=<optimized out>) at /usr/src/sys/dev/pci/pci.c:4733 #27 0xffffffff80b78269 in BUS_DRIVER_ADDED (_dev=0xfffff80001b11100, _driver=0xffffffff8333b420 <cxgb_controller_driver>) at ./bus_if.h:210 #28 devclass_driver_added (dc=dc@entry=0xfffff80001717300, driver=0xffffffff8333b420 <cxgb_controller_driver>) at /usr/src/sys/kern/subr_bus.c:603 #29 0xffffffff80b8065b in device_do_deferred_actions () at /usr/src/sys/kern/subr_bus.c:5543 #30 0xffffffff80b7ff5f in devctl2_ioctl (cdev=<optimized out>, cmd=2157462540, data=0xfffff80024647a00 "", fflag=<optimized out>, td=<optimized out>) at /usr/src/sys/kern/subr_bus.c:5826 #31 0xffffffff809cc79b in devfs_ioctl (ap=0xfffffe00aab0bc58) at /usr/src/sys/fs/devfs/devfs_vnops.c:952 #32 0xffffffff80c3a91e in VOP_IOCTL (vp=<optimized out>, command=<optimized out>, data=<optimized out>, --Type <RET> for more, q to quit, c to continue without paging--c fflag=<optimized out>, cred=<optimized out>, td=<optimized out>) at ./vnode_if.h:633 #33 0xffffffff80c3a91e in vn_ioctl (fp=<optimized out>, com=18446741877550004080, data=0xfffffe00acbb9ed8, active_cred=0xc0306938, td=0x0) #34 0xffffffff809ccdfe in devfs_ioctl_f (fp=0xfffff80024451000, com=18446741877550004080, data=0xfffffe00acbb9ed8, cred=0xc0306938, td=0x0) at /usr/src/sys/fs/devfs/devfs_vnops.c:883 #35 0xffffffff80bacad5 in fo_ioctl (fp=0xfffff80006f63d20, com=2157462540, data=0xfffffe00acbb9ed8, active_cred=0xc0306938, td=0xfffff80006eca740) at /usr/src/sys/sys/file.h:370 #36 kern_ioctl (td=td@entry=0xfffff80006eca740, fd=<optimized out>, com=com@entry=2157462540, data=0xfffffe00acbb9ed8 "", data@entry=0xfffff80024647a00 "") at /usr/src/sys/kern/sys_generic.c:807 #37 0xffffffff80bac81f in sys_ioctl (td=<optimized out>, uap=0xfffff80006ecab40) at /usr/src/sys/kern/sys_generic.c:715 #38 0xffffffff810252c5 in syscallenter (td=0xfffff80006eca740) at /usr/src/sys/amd64/amd64/../../kern/subr_syscall.c:191 #39 amd64_syscall (td=0xfffff80006eca740, traced=0) at /usr/src/sys/amd64/amd64/trap.c:1194 #40 <signal handler called> #41 0x00003925bf8095fa in ?? () Backtrace stopped: Cannot access memory at address 0x3925bccb1db8 What can I do to gather more information or further investigate?
*** Bug 282373 has been marked as a duplicate of this bug. ***
I see reports on the OPNSense forums of at least 2 or 3 other users hitting what appears to be the same issue. https://forum.opnsense.org/index.php?topic=42194 I built a debug kernel with -O0 to see if there was any additional information I could glean, and got a slightly different backtrace. I'm guessing some of the function calls were inlined as part of the optimization? Here's the backtrace from kgdb: #0 0xffffffff80fed9fb in doadump (textdump=0) at /usr/src/sys/kern/kern_shutdown.c:405 #1 0xffffffff805eef47 in db_dump (dummy=-2130291755, dummy2=false, dummy3=-1, dummy4=0xfffffe009a386460 "") at /usr/src/sys/ddb/db_command.c:591 #2 0xffffffff805eed36 in db_command (last_cmdp=0xffffffff81fe75a0 <db_last_command>, cmd_table=0x0, dopager=false) at /usr/src/sys/ddb/db_command.c:504 #3 0xffffffff805eee1f in db_command_script (command=0xffffffff81fe86c3 <db_recursion_data+3> "dump") at /usr/src/sys/ddb/db_command.c:569 #4 0xffffffff805f61da in db_script_exec (scriptname=0xffffffff8195c9e2 "kdb.enter.default", warnifnotfound=0) at /usr/src/sys/ddb/db_script.c:302 #5 0xffffffff805f608d in db_script_kdbenter (eventname=0xffffffff81a69c8c "panic") at /usr/src/sys/ddb/db_script.c:325 #6 0xffffffff805f3407 in db_trap (type=3, code=0) at /usr/src/sys/ddb/db_main.c:267 #7 0xffffffff81065ca8 in kdb_trap (type=3, code=0, tf=0xfffffe009a386a30) at /usr/src/sys/kern/subr_kdb.c:790 #8 0xffffffff817ea671 in trap (frame=0xfffffe009a386a30) at /usr/src/sys/amd64/amd64/trap.c:608 #9 0xffffffff817eb848 in trap_check (frame=0xfffffe009a386a30) at /usr/src/sys/amd64/amd64/trap.c:664 #10 <signal handler called> #11 breakpoint () at /usr/src/sys/amd64/include/cpufunc.h:62 #12 0xffffffff81065050 in kdb_enter (why=0xffffffff81a69c8c "panic", msg=0xffffffff81a69c8c "panic") at /usr/src/sys/kern/subr_kdb.c:555 #13 0xffffffff80fee0bd in vpanic (fmt=0xffffffff819686a6 "%s", ap=0xfffffe009a386c90) at /usr/src/sys/kern/kern_shutdown.c:954 #14 0xffffffff80fed99e in panic (fmt=0xffffffff819686a6 "%s") at /usr/src/sys/kern/kern_shutdown.c:891 #15 0xffffffff817eb0b8 in trap_fatal (frame=0xfffffe009a387080, eva=0) at /usr/src/sys/amd64/amd64/trap.c:952 #16 0xffffffff817eb391 in trap_pfault (frame=0xfffffe009a387080, usermode=false, signo=0x0, ucode=0x0) at /usr/src/sys/amd64/amd64/trap.c:794 #17 0xffffffff817ea267 in trap (frame=0xfffffe009a387080) at /usr/src/sys/amd64/amd64/trap.c:442 #18 0xffffffff817eb848 in trap_check (frame=0xfffffe009a387080) at /usr/src/sys/amd64/amd64/trap.c:664 #19 <signal handler called> #20 0x0000000000000000 in ?? () #21 0xffffffff811d260a in ifmedia_ioctl (ifp=0xfffff800017e7800, ifr=0xfffffe009a3872a8, ifm=0xfffffe00ae814ed8, cmd=3224398136) at /usr/src/sys/net/if_media.c:293 #22 0xffffffff83d2bd4a in cxgb_ioctl (ifp=0xfffff800017e7800, command=3224398136, data=0xfffffe009a3872a8 "") at /usr/src/sys/dev/cxgb/cxgb_main.c:2045 #23 0xffffffff811c15fb in if_ioctl (ifp=0xfffff800017e7800, cmd=3224398136, data=0xfffffe009a3872a8) at /usr/src/sys/net/if.c:4864 #24 0xffffffff813b54e2 in get_operstate_ether (ifp=0xfffff800017e7800, pstate=0xfffffe009a387358) at /usr/src/sys/netlink/route/iface.c:124 #25 0xffffffff813b4c6b in get_operstate (ifp=0xfffff800017e7800, pstate=0xfffffe009a387358) at /usr/src/sys/netlink/route/iface.c:181 #26 0xffffffff813b4834 in dump_iface (nw=0xfffffe009a3873d0, ifp=0xfffff800017e7800, hdr=0xfffffe009a387410, if_flags_mask=0) at /usr/src/sys/netlink/route/iface.c:310 #27 0xffffffff813b4124 in rtnl_handle_ifevent (ifp=0xfffff800017e7800, nlmsg_type=16, if_flags_mask=0) at /usr/src/sys/netlink/route/iface.c:1411 #28 0xffffffff813b43d2 in rtnl_handle_ifattach (arg=0x0, ifp=0xfffff800017e7800) at /usr/src/sys/netlink/route/iface.c:1419 #29 0xffffffff811b6800 in if_attach_internal (ifp=0xfffff800017e7800, vmove=false) at /usr/src/sys/net/if.c:957 #30 0xffffffff811b61d9 in if_attach (ifp=0xfffff800017e7800) at /usr/src/sys/net/if.c:772 #31 0xffffffff811c9bad in ether_ifattach (ifp=0xfffff800017e7800, lla=0xfffffe00ae814f38 "") at /usr/src/sys/net/if_ethersubr.c:1001 #32 0xffffffff83d2aea5 in cxgb_port_attach (dev=0xfffff80001c4cb00) at /usr/src/sys/dev/cxgb/cxgb_main.c:1044 #33 0xffffffff81049845 in DEVICE_ATTACH (dev=0xfffff80001c4cb00) at ./device_if.h:195 #34 0xffffffff81048f7c in device_attach (dev=0xfffff80001c4cb00) at /usr/src/sys/kern/subr_bus.c:2591 #35 0xffffffff81048d86 in device_probe_and_attach (dev=0xfffff80001c4cb00) at /usr/src/sys/kern/subr_bus.c:2546 #36 0xffffffff8104b28c in bus_generic_attach (dev=0xfffff80001d75700) at /usr/src/sys/kern/subr_bus.c:3426 #37 0xffffffff83d28f73 in cxgb_controller_attach (dev=0xfffff80001d75700) at /usr/src/sys/dev/cxgb/cxgb_main.c:644 #38 0xffffffff81049845 in DEVICE_ATTACH (dev=0xfffff80001d75700) at ./device_if.h:195 #39 0xffffffff81048f7c in device_attach (dev=0xfffff80001d75700) at /usr/src/sys/kern/subr_bus.c:2591 #40 0xffffffff81048d86 in device_probe_and_attach (dev=0xfffff80001d75700) at /usr/src/sys/kern/subr_bus.c:2546 #41 0xffffffff80b29d88 in pci_driver_added (dev=0xfffff80001d75800, driver=0xffffffff83d46790 <cxgb_controller_driver>) at /usr/src/sys/dev/pci/pci.c:4733 #42 0xffffffff8105043d in BUS_DRIVER_ADDED (_dev=0xfffff80001d75800, _driver=0xffffffff83d46790 <cxgb_controller_driver>) at ./bus_if.h:210 #43 0xffffffff810454e5 in devclass_driver_added (dc=0xfffff800010f4b80, driver=0xffffffff83d46790 <cxgb_controller_driver>) at /usr/src/sys/kern/subr_bus.c:643 #44 0xffffffff81052178 in device_do_deferred_actions () at /usr/src/sys/kern/subr_bus.c:5588 #45 0xffffffff81051be4 in devctl2_ioctl (cdev=0xfffff80001108400, cmd=2157462540, data=0xfffff80001c4cd00 "", fflag=1, td=0xfffff8004fb0d740) at /usr/src/sys/kern/subr_bus.c:5871 #46 0xffffffff80daf5c7 in devfs_ioctl (ap=0xfffffe009a387b58) at /usr/src/sys/fs/devfs/devfs_vnops.c:952 #47 0xffffffff8191d146 in VOP_IOCTL_APV (vop=0xffffffff81ec7378 <devfs_specops>, a=0xfffffe009a387b58) at vnode_if.c:1229 #48 0xffffffff81191106 in VOP_IOCTL (vp=0xfffff8009b8fb380, command=2157462540, data=0xfffff80001c4cd00, fflag=1, cred=0xfffff80001f94700, td=0xfffff8004fb0d740) at ./vnode_if.h:637 #49 0xffffffff811881b8 in vn_ioctl (fp=0xfffff80056273f00, com=2157462540, data=0xfffff80001c4cd00, active_cred=0xfffff80001f94700, td=0xfffff8004fb0d740) at /usr/src/sys/kern/vfs_vnops.c:1747 #50 0xffffffff80dafca7 in devfs_ioctl_f (fp=0xfffff80056273f00, com=2157462540, data=0xfffff80001c4cd00, cred=0xfffff80001f94700, td=0xfffff8004fb0d740) at /usr/src/sys/fs/devfs/devfs_vnops.c:883 #51 0xffffffff810a6d3e in fo_ioctl (fp=0xfffff80056273f00, com=2157462540, data=0xfffff80001c4cd00, active_cred=0xfffff80001f94700, td=0xfffff8004fb0d740) at /usr/src/sys/sys/file.h:370 #52 0xffffffff810a6b14 in kern_ioctl (td=0xfffff8004fb0d740, fd=3, com=2157462540, data=0xfffff80001c4cd00 "") at /usr/src/sys/kern/sys_generic.c:807 #53 0xffffffff810a6771 in sys_ioctl (td=0xfffff8004fb0d740, uap=0xfffff8004fb0db40) at /usr/src/sys/kern/sys_generic.c:715 #54 0xffffffff817ec97f in syscallenter (td=0xfffff8004fb0d740) at /usr/src/sys/amd64/amd64/../../kern/subr_syscall.c:191 #55 0xffffffff817ec095 in amd64_syscall (td=0xfffff8004fb0d740, traced=0) at /usr/src/sys/amd64/amd64/trap.c:1194 #56 <signal handler called> #57 0x0000077e757ea5fa in ?? () Backtrace stopped: Cannot access memory at address 0x77e72dc3628 The same panic in ifmedia_ioctl() occurs, trying to call the (*ifm->status) function and ifm->status = 0x. The backtrace shows a call to ether_ifattach() in cxgb_port_attach(). This is at /usr/src/sys/dev/cxgb/cxgb_main.c:1044 The status callbacks are set by ifmedia_init() at line 1059, so the call in ifmedia_ioctl() to (*ifm->status) downstream of ether_ifattach() will always fail. The interesting question to me isn't why it fails, it's how it ever worked once netlink was implemented? A slightly different sequence of netlink / ioctl calls in OPNSense 2.7 startup vs. FreeBSD 14.1? According to git blame, the call to ether_ifattach(ifp, p->hw_addr); and subsequent call to ifmedia_init() were part of the very first commit to cxgb on May 13, 2007, with minimal changes since then. As a test, I tried moving ifmedia_init() to before ether_ifattach() and the system boots successfully, without crashing. This is using the stable/14 branch.
Created attachment 254602 [details] Patch which appears to fix the panic
Patch looks reasonable as previously discussed. In fact I looked at cxgbe code (so not cxgb) and couldn't find the obvious issue. ;) Cheers, Franco
I tried a T320 card on latest main as of today but did not run into any problems, probably because there weren't any netlink listeners at the time of attach. That said, the attached patch looks correct and I'm planning to commit it as soon as tinderbox completes. I'll set author to the following: Author: ScottD <biscuits.carry.0j@icloud.com>
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=f2daf89954a45c7eed22990dd4cf2cf879763dc0 commit f2daf89954a45c7eed22990dd4cf2cf879763dc0 Author: ScottD <biscuits.carry.0j@icloud.com> AuthorDate: 2024-10-28 20:48:16 +0000 Commit: Navdeep Parhar <np@FreeBSD.org> CommitDate: 2024-10-28 23:10:05 +0000 cxgb(4): Register ifmedia callbacks before ether_ifattach. This prevents a panic that occurs if netlink tries to invoke the driver's media callbacks during ifattach. PR: 282374 Reported by: ScottD <biscuits.carry.0j@icloud.com> MFC after: 3 days sys/dev/cxgb/cxgb_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=843c1b516019efec22295234bdda26b838b1e6b7 commit 843c1b516019efec22295234bdda26b838b1e6b7 Author: ScottD <biscuits.carry.0j@icloud.com> AuthorDate: 2024-10-28 20:48:16 +0000 Commit: Navdeep Parhar <np@FreeBSD.org> CommitDate: 2024-10-31 01:09:06 +0000 cxgb(4): Register ifmedia callbacks before ether_ifattach. This prevents a panic that occurs if netlink tries to invoke the driver's media callbacks during ifattach. PR: 282374 Reported by: ScottD <biscuits.carry.0j@icloud.com> (cherry picked from commit f2daf89954a45c7eed22990dd4cf2cf879763dc0) sys/dev/cxgb/cxgb_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)