As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes emulators/dosbox-x to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ dos_programs.cpp:7692:17: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here 7692 | test_string dst; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ dos_programs.cpp:8893:14: warning: variable 'open' set but not used [-Wunused-but-set-variable] 8893 | bool open=false; | ^ This can be fixed by using char16_t for the 'test_char_t` type, and by adding a few inline wrappers to perform the required casting. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
Created attachment 254596 [details] emulators/dosbox-x: fix build with libc++ 19
Hello Dimitry, Thanks for patch. Builds fine on main-n273280-ac1d519c01ca. I will do some run tests and commit it tommorow.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=573cdb2e7e34d6e97828e0b42456b17fc7c13f4b commit 573cdb2e7e34d6e97828e0b42456b17fc7c13f4b Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-10-29 08:29:00 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-10-29 08:30:50 +0000 emulators/dosbox-x: Fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes emulators/dosbox-x to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ dos_programs.cpp:7692:17: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here 7692 | test_string dst; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ dos_programs.cpp:8893:14: warning: variable 'open' set but not used [-Wunused-but-set-variable] 8893 | bool open=false; | ^ This can be fixed by using char16_t for the 'test_char_t` type, and by adding a few inline wrappers to perform the required casting. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 282386 MFH: 2024Q4 .../files/patch-src_dos_dos__programs.cpp (new) | 24 +++++++++++++++ .../files/patch-src_dos_drive__iso.cpp (new) | 34 ++++++++++++++++++++++ 2 files changed, 58 insertions(+)
A commit in branch 2024Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=74d67a6f3e28800b7b6904d0dbd3a2fc071b1e52 commit 74d67a6f3e28800b7b6904d0dbd3a2fc071b1e52 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-10-29 08:29:00 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-10-29 08:31:59 +0000 emulators/dosbox-x: Fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes emulators/dosbox-x to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ dos_programs.cpp:7692:17: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here 7692 | test_string dst; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ dos_programs.cpp:8893:14: warning: variable 'open' set but not used [-Wunused-but-set-variable] 8893 | bool open=false; | ^ This can be fixed by using char16_t for the 'test_char_t` type, and by adding a few inline wrappers to perform the required casting. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 282386 MFH: 2024Q4 (cherry picked from commit 573cdb2e7e34d6e97828e0b42456b17fc7c13f4b) .../files/patch-src_dos_dos__programs.cpp (new) | 24 +++++++++++++++ .../files/patch-src_dos_drive__iso.cpp (new) | 34 ++++++++++++++++++++++ 2 files changed, 58 insertions(+)
Committed, thank you!