Bug 282426 - graphics/p5-Image-ExifTool: Update to 13.00
Summary: graphics/p5-Image-ExifTool: Update to 13.00
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://exiftool.org/history.html
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-30 17:49 UTC by Sergei Vyshenski
Modified: 2024-10-31 01:14 UTC (History)
3 users (show)

See Also:
devnull: maintainer-feedback+


Attachments
git format-patch -1 main (19.83 KB, patch)
2024-10-30 17:51 UTC, Sergei Vyshenski
no flags Details | Diff
git format-patch -1 main (11.26 KB, patch)
2024-10-30 23:14 UTC, Sergei Vyshenski
no flags Details | Diff
git format-patch -1 main (2.57 KB, patch)
2024-10-30 23:55 UTC, Sergei Vyshenski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2024-10-30 17:49:28 UTC
https://exiftool.org/history.html
graphics/p5-Image-ExifTool: Update to 13.00

- update 12.76 (production release) -> 13.00 (production release)
ChangeLog: https://exiftool.org/history.html

- "portlint -AC" is happy.
- "portclippy Makefile" is happy.
- "portfmt -D Makefile" is happy.
- Tested with:
14.1-RELEASE-p6
portlint 2.22.3
portfmt 1.1.5
pkg 1.21.3
poudriere-git-3.4.99.20240811
perl 5.36.3_2
openssl 3.0.13
ssl=base
- built-in perl tests in a clean poudriere jail say: PASS.
Comment 1 Sergei Vyshenski 2024-10-30 17:51:41 UTC
Created attachment 254647 [details]
git format-patch -1 main
Comment 2 Sergei Vyshenski 2024-10-30 22:47:38 UTC
Vladimir,

Please note, that I am not maintainer of this port.
This port
graphics/p5-Image-ExifTool
follows production releases only.
Instead, my port
graphics/p5-Image-ExifTool-devel
follows both development and production releases.

Best, 
Sergei
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-30 22:51:24 UTC
Why did you move lines with man pages in pkg-plist?
%%PERL5_MAN3%% = lib/perl5/site_perl/man/man3
%%SITE_PERL%%/File = lib/perl5/site_perl/File

And bin/exiftool must be 1st.

(In reply to Sergei Vyshenski from comment #2)
Ok, I'll wait maintainer.
Comment 4 Sergei Vyshenski 2024-10-30 23:14:39 UTC
Created attachment 254782 [details]
git format-patch -1 main

My fault.

With a new patch regenerated pkg-plist anew by "make makeplist".
Now it begins with "bin/exiftool".
It passes all tests and checks as before.

But sorry, afraid I do not understand your lines:

   Why did you move lines with man pages in pkg-plist?
   %%PERL5_MAN3%% = lib/perl5/site_perl/man/man3
   %%SITE_PERL%%/File = lib/perl5/site_perl/File
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-30 23:40:17 UTC
(In reply to Sergei Vyshenski from comment #4)
Default substitution for "%%PERL5_MAN3%%" is "lib/perl5/site_perl/man/man3", for "%%SITE_PERL%%" is "lib/perl5/site_perl".
"lib/perl5/site_perl/File" is early than "lib/perl5/site_perl/man/man3" in alphabetical order.
Comment 6 Sergei Vyshenski 2024-10-30 23:42:53 UTC
Thank you for clarification. 
Does the new patch solve the problem?
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-30 23:43:14 UTC
Don't need lines "%%PORTDOCS%%%%DOCSDIR%%/*" - "PORTDOCS=*" and these lines "self".
Comment 8 Sergei Vyshenski 2024-10-30 23:55:53 UTC
Created attachment 254783 [details]
git format-patch -1 main

Thank you very much again.
The third patch passes all tests and checks as before.
Comment 9 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-31 00:00:05 UTC
(In reply to Sergei Vyshenski from comment #8)
LGFM!
Waiting maintainer.
Comment 10 Rafael Grether 2024-10-31 00:18:52 UTC
Thanks Sergey, for providing the Patch and subsequent corrections.

Vladimir Druzenko, thats Ok for me.
Patch approved!
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-10-31 01:13:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=406bd17d8559ff9f1ec2dad7de979b90566326c7

commit 406bd17d8559ff9f1ec2dad7de979b90566326c7
Author:     Sergei Vyshenski <svysh.fbsd@gmail.com>
AuthorDate: 2024-10-31 01:09:07 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-10-31 01:12:38 +0000

    graphics/p5-Image-ExifTool: Update 12.76 → 13.00

    ChangeLog: https://exiftool.org/history.html

    PR:             282426
    Approved by:    Rafael Grether <devnull@apt322.org> (maintainer)

 graphics/p5-Image-ExifTool/Makefile  | 2 +-
 graphics/p5-Image-ExifTool/distinfo  | 6 +++---
 graphics/p5-Image-ExifTool/pkg-plist | 5 +++++
 3 files changed, 9 insertions(+), 4 deletions(-)
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-31 01:14:53 UTC
Thanks.