Bug 282469 - security/sssd2: Let krb5_store_password_if_offline feature work without procfs
Summary: security/sssd2: Let krb5_store_password_if_offline feature work without procfs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Hixson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-01 15:24 UTC by Mark Johnston
Modified: 2024-12-06 20:59 UTC (History)
2 users (show)

See Also:
jhixson: maintainer-feedback+

Attachments
proposed patch (9.86 KB, patch)
2024-11-01 15:24 UTC, Mark Johnston 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Johnston freebsd_committer freebsd_triage 2024-11-01 15:24:40 UTC 
Created attachment 254847 [details]
proposed patch

Attached is a patch which rewrites the UID enumeration code to use sysctl instead of procfs on FreeBSD, following up on PR 279255.  This is a bit more code, but doesn't require any special mounts so makes sssd2 behave more like a native FreeBSD application.

Gleb, John, I wonder if you could help test this?  Our current sssd2 setup has some issues that make testing a bit tricky at the moment.
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-11-04 20:48:19 UTC 
The code looks good to me and I tested it with our local AD domain. I don't really remember what action highlighted this problem initially, but at least nothing gets broken by this change.
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2024-11-04 23:10:27 UTC 
(In reply to Gleb Popov from comment #1)
Thanks for testing.  The problem was triggered by having krb5_store_password_if_offline=yes set in the sssd2 configuration, and starting sssd2 with some krb provider configured.  In particular, this should now work without procfs mounted.
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2024-11-06 13:34:18 UTC 
> krb5_store_password_if_offline=yes set in the sssd2 configuration, and starting sssd2 with some krb provider configured.

That was exactly the context I was testing in.
Comment 4 John Hixson freebsd_committer freebsd_triage 2024-12-04 05:31:41 UTC 
Looks good to me. I'll get it committed this week. Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-12-06 20:49:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f53142e16976397a188f1d44ec743926b34feeb8

commit f53142e16976397a188f1d44ec743926b34feeb8
Author:     John Hixson <jhixson@FreeBSD.org>
AuthorDate: 2024-12-06 20:47:24 +0000
Commit:     John Hixson <jhixson@FreeBSD.org>
CommitDate: 2024-12-06 20:48:44 +0000

    security/sssd2: bump port revision

    Added patch for finding UIDs without using procfs

    PR: 282469

 security/sssd2/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 John Hixson freebsd_committer freebsd_triage 2024-12-06 20:59:29 UTC 
Committed. Thank you!