Bug 282986 - lang/siod: fix build with clang 19
Summary: lang/siod: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2024-11-26 15:44 UTC by Mikhail T.
Modified: 2024-11-27 12:06 UTC (History)
1 user (show)

See Also:

Attachments
Fix compiler-warnings raised by the new clang 19 (7.96 KB, patch)
2024-11-26 15:44 UTC, Mikhail T. 		freebsd-2024: maintainer-approval+
Details | Diff
git format-patch (8.13 KB, patch)
2024-11-26 20:13 UTC, Mikhail T. 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2024-11-26 15:44:02 UTC 
Created attachment 255469 [details]
Fix compiler-warnings raised by the new clang 19

The patch fixes new compiler-warnings raised by clang-19.

(I am the port's maintainer.)
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-11-26 15:44:02 UTC 
Maintainer informed via mail
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2024-11-26 16:26:45 UTC 
You're doing something strange with your patches and they don't apply directly.  Use "git-format-patch" to create them ideally.  Do not change anything about the generated patch files.
Comment 3 Mikhail T. 2024-11-26 20:13:58 UTC 
Created attachment 255473 [details]
git format-patch

> Use "git-format-patch" to create them ideally

Here goes...
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-11-27 12:02:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e1e10aedfb9998dfb21d28c0a9d86c8e07f6539f

commit e1e10aedfb9998dfb21d28c0a9d86c8e07f6539f
Author:     Mikhail Teterin <mi@FreeBSD.org>
AuthorDate: 2024-11-26 16:25:28 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-11-27 11:59:49 +0000

    lang/siod: resolve new warnings raised by the increasingly-picky clang-19

    PR:             282986

 lang/siod/files/patch-lib | 113 ++++++++++++++++++++++++++++++++++++----------
 1 file changed, 88 insertions(+), 25 deletions(-)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-11-27 12:06:05 UTC 
Thank you for your contribution.