Bug 283013 - [exp-run] update LLVM_DEFAULT to 18
Summary: [exp-run] update LLVM_DEFAULT to 18
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Port Management Team
URL:
Keywords:
Depends on: 280957 283126 283128 283131 283132 283134 284266
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-27 20:57 UTC by Dimitry Andric
Modified: 2025-01-23 20:45 UTC (History)
6 users (show)

See Also:


Attachments
Bump LLVM_DEFAULT to 18 (536 bytes, patch)
2024-11-27 20:59 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-11-27 20:57:40 UTC
This was also suggested in bug 282436, but I'd expect some fallout, so please perform an exp-run with LLVM_DEFAULT set to 18.

(I would even like to do try setting it to 19 since that is currently the most recent stable version from upstream, but maybe it is better to file a separate request? Please let me know)
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-11-27 20:59:18 UTC
Created attachment 255499 [details]
Bump LLVM_DEFAULT to 18
Comment 3 Dimitry Andric freebsd_committer freebsd_triage 2024-12-04 15:02:16 UTC
* bug 283126 for emulators/mame
Comment 4 Dimitry Andric freebsd_committer freebsd_triage 2024-12-04 16:18:14 UTC
* bug 283128 for devel/spirv-llvm-translator

Note: this is one way to solve the lang/clover error, without having to adjust all spirv-llvm-translator consumers. On the other hand, there are only about 5 of them, so another way would be to go over all those consumers.
Comment 5 Dimitry Andric freebsd_committer freebsd_triage 2024-12-04 18:54:53 UTC
* bug 283131 for security/heimdal (not strictly needed but nice to have)
* bug 283132 for security/heimdal-devel
Comment 6 Dimitry Andric freebsd_committer freebsd_triage 2024-12-04 20:32:35 UTC
* bug 280957 for lang/clover (specifically the patch in bug 280957 comment 8)
Comment 7 Dimitry Andric freebsd_committer freebsd_triage 2024-12-04 20:41:17 UTC
* bug 283134 for lang/ldc
Comment 8 Dimitry Andric freebsd_committer freebsd_triage 2025-01-05 13:55:55 UTC
All dependent bugs have now been fixed, I think it is now reasonable to do the actual LLVM_DEFAULT bump. Or would you prefer doing another run?
Comment 10 Dimitry Andric freebsd_committer freebsd_triage 2025-01-21 20:53:34 UTC
(In reply to Antoine Brodin from comment #9)
For me, lang/dotnet built successfully against llvm 18 (on ports 92ad40fd8c53bb6336f3596016ea2a7dc6ab2b47, as of 2025-01-20T02:16:50+03:00):

...
=======================<phase: package        >============================
===== env: 'PKG_NOTES=build_timestamp built_by' 'PKG_NOTE_build_timestamp=2025-01-21T19:10:45+0000' 'PKG_NOTE_built_by=poudriere-git-3.4.2' NO_DEPENDS=yes USER=nobody UID=65534 GID=65534
===>  Building packages for dotnet-9.0.1
===>   Building dotnet-9.0.1
===========================================================================
=>> Cleaning up wrkdir
===>  Cleaning for dotnet-9.0.1
build of lang/dotnet | dotnet-9.0.1 ended at Tue Jan 21 21:39:00 CET 2025
build time: 01:28:17
Comment 11 Dimitry Andric freebsd_committer freebsd_triage 2025-01-22 17:12:54 UTC
* bug 284266 for math/heyoka
Comment 12 Dimitry Andric freebsd_committer freebsd_triage 2025-01-22 17:52:34 UTC
(In reply to Dimitry Andric from comment #11)
Note, for math/heyoka I had to apply a fix for llvm18 and higher, which use 1 for their minor version numbers, while llvm17 and earlier use 0.

CMake's find_package() needs the minor version number set correctly, otherwise it will not be able to find the LLVM package. This could possibly also apply to other ports that use LLVM via other mechanisms.

Maybe at some point there should be a structural solution, i.e. in Mk/Uses/cmake.mk and Mk/Uses/llvm.mk.
Comment 13 Dimitry Andric freebsd_committer freebsd_triage 2025-01-23 20:06:57 UTC
(In reply to Dimitry Andric from comment #10)
Similar to lang/dotnet, I had no issues building:
* devel/llvm-cheri
* devel/llvm16@lite
* lang/dotnet8

It is likely the reported errors were due to OOM conditions, timeouts, or the like.
Comment 14 Dimitry Andric freebsd_committer freebsd_triage 2025-01-23 20:45:01 UTC
(In reply to Dimitry Andric from comment #0)
I submitted bug 284297 for bumping LLVM_DEFAULT to 19.