Upstream clang >= 16 made -Wimplicit-function-declaration into an error by default. In the base system, this change was reverted to reduce the fallout in ports, because there are many problematic configure scripts. For security/heimdal this also applies, so for building the port with devel/llvm16 or higher we need to add -Wno-implicit-function-declaration to CFLAGS. While here, use LDFLAGS+= for -Wl,--undefined-version, to avoid overwriting any user-specified LDFLAGS.
Created attachment 255630 [details] security/heimdal: fix with stock clang >= 16
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4d5d01f42f436a1834773cc616fb7a693acfbc74 commit 4d5d01f42f436a1834773cc616fb7a693acfbc74 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-12-04 18:49:29 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2025-01-05 13:52:58 +0000 security/heimdal: fix with stock clang >= 16 Upstream clang >= 16 made -Wimplicit-function-declaration into an error by default. In the base system, this change was reverted to reduce the fallout in ports, because there are many problematic configure scripts. For security/heimdal this also applies, so for building the port with devel/llvm16 or higher we need to add -Wno-implicit-function-declaration to CFLAGS. While here, use LDFLAGS+= for -Wl,--undefined-version, to avoid overwriting any user-specified LDFLAGS. PR: 283131 Approved by: maintainer timeout (2 weeks) MFH: 2025Q1 security/heimdal/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
A commit in branch 2025Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c044b16d8a349de70c18a5cb3bad45ba944524a3 commit c044b16d8a349de70c18a5cb3bad45ba944524a3 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-12-04 18:49:29 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2025-01-05 13:54:07 +0000 security/heimdal: fix with stock clang >= 16 Upstream clang >= 16 made -Wimplicit-function-declaration into an error by default. In the base system, this change was reverted to reduce the fallout in ports, because there are many problematic configure scripts. For security/heimdal this also applies, so for building the port with devel/llvm16 or higher we need to add -Wno-implicit-function-declaration to CFLAGS. While here, use LDFLAGS+= for -Wl,--undefined-version, to avoid overwriting any user-specified LDFLAGS. PR: 283131 Approved by: maintainer timeout (2 weeks) MFH: 2025Q1 (cherry picked from commit 4d5d01f42f436a1834773cc616fb7a693acfbc74) security/heimdal/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)