Bug 283184 - net/uriparser: Utilize framework for unit tests
Summary: net/uriparser: Utilize framework for unit tests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-07 17:04 UTC by Daniel Engberg
Modified: 2024-12-10 19:41 UTC (History)
1 user (show)

See Also:
svysh.fbsd: maintainer-feedback+

Attachments
Patch for uriparser (1.08 KB, patch)
2024-12-07 17:04 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-12-07 17:04:53 UTC 
Created attachment 255685 [details]
Patch for uriparser

Instead of having tests as an option and enabled by default build everything on demand
Comment 1 Sergei Vyshenski 2024-12-07 21:55:14 UTC 
Daniel,

As far as I can see, both old and new approaches to run tests work just fine here. If you prefer the new one, this patch is ok with me.

But to be on a safe side, can I ask to retain a version check like this:

TEST_DEPENDS=	googletest>=1.10.0:devel/googletest

instead of yours:

TEST_DEPENDS=	googletest>0:devel/googletest

Regards, 
Sergei
(as a maintainer)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-10 19:41:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=197b5473c2c2f1e899dd234f6f9a76307e89453b

commit 197b5473c2c2f1e899dd234f6f9a76307e89453b
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-12-10 19:15:14 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-12-10 19:40:05 +0000

    net/uriparser: Utilize framework for unit tests

    Instead of having unit tests as an option and enabled by default
    build when requested.

    PR:             283184
    Reviewed by:    Sergei Vyshenski <svysh.fbsd@gmail.com> (maintainer)

 net/uriparser/Makefile | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-12-10 19:41:59 UTC 
Committed, thanks!