Bug 283200 - www/caddy typo in files/pkg-message.in
Summary: www/caddy typo in files/pkg-message.in
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-08 12:58 UTC by Roman Gromov
Modified: 2024-12-09 07:20 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)

Attachments
Patch to fix the typo (819 bytes, patch)
2024-12-08 12:58 UTC, Roman Gromov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Gromov 2024-12-08 12:58:05 UTC 
Created attachment 255712 [details]
Patch to fix the typo

There seems to be a mistake in the documentation. It instructs you to enable caddy using `service enable caddy`, but it should actually be `service caddy enable`. This error makes copying and pasting the command problematic.
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2024-12-08 20:24:41 UTC 
I assume you're using a quarterly branch? This was fixed recently in main, and it'll make its way automatically to quarterly soon.
Comment 2 Roman Gromov 2024-12-08 21:51:23 UTC 
Thank you for your quick response to the bug report.

Indeed, there were recent changes in the main branch, but they only affected the file caddy.in. The file pkg-message.in remained unchanged and contains the typo in the main branch.

https://cgit.freebsd.org/ports/tree/www/caddy/files/pkg-message.in
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2024-12-08 22:31:49 UTC 
Oh! I completely blew right past that. Thank you!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-12-08 22:45:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=362954a158482d4bb15bfc8c0d97c4ff9361e9ee

commit 362954a158482d4bb15bfc8c0d97c4ff9361e9ee
Author:     Adam Weinberger <adamw@FreeBSD.org>
AuthorDate: 2024-12-08 22:44:17 +0000
Commit:     Adam Weinberger <adamw@FreeBSD.org>
CommitDate: 2024-12-08 22:45:31 +0000

    www/caddy: Fix service command in pkg-message

    PR:             283200
    Reported by:    Roman Gromov

 www/caddy/files/pkg-message.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2024-12-08 22:46:26 UTC 
OK should be fixed for real this time.
Comment 6 Roman Gromov 2024-12-09 07:20:48 UTC 
Thank you so much!