Bug 283588 - devel/libunistring: Update to 1.3
Summary: devel/libunistring: Update to 1.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://savannah.gnu.org/news/?id=10682
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-25 10:19 UTC by Daniel Engberg
Modified: 2025-01-15 19:49 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (takefu)


Attachments
Patch for libunistring (1.86 KB, patch)
2024-12-25 10:19 UTC, Daniel Engberg
no flags Details | Diff
libunistring-1.3.patch (2.38 KB, patch)
2025-01-14 05:45 UTC, takefu
takefu: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-12-25 10:19:23 UTC
Created attachment 256129 [details]
Patch for libunistring

* Adjust Makefile layout to closer follow Porters Handbook

Compile and runtime tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist, make test)

Poudriere testport OK 13.4-RELEASE (amd64)
Poudriere testport OK 14.2-RELEASE (amd64)

Tested with following consumers in Poudriere on 13.4-RELEASE (amd64):
audio/owntone
biology/ncbi-toolkit
cad/lepton-eda
cad/opencascade
deskutils/gnome-characters
devel/notcurses
dns/libidn2
dns/libpsl
editors/rehex
ftp/wget
graphics/podofo09
lang/guile2
lang/guile3
mail/mailutils
mail/mutt
misc/boxes
net/pacemaker2 (fails, unrelated plist-issue)
net/zmap
security/gnutls
security/sssd
security/sssd2
sysutils/libdnf
www/lagrange
x11/lxhotkey

-----

One unit test fails (this also fails on 1.2):

FAIL test-u8-strncpy (exit status: 139)

Can you please have a look and if possible upstream a patch and/or report upstream?
Comment 1 takefu 2025-01-14 05:45:52 UTC
Created attachment 256686 [details]
libunistring-1.3.patch

(In reply to Daniel Engberg from comment #0)

14.2-RELEASE AMD64 Test succeeds.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-01-15 19:42:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=80697b29aed2fb08eadfbf5742d5a0ed991e2185

commit 80697b29aed2fb08eadfbf5742d5a0ed991e2185
Author:     takefu <takefu@airport.fm>
AuthorDate: 2025-01-15 19:24:40 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2025-01-15 19:42:17 +0000

    devel/libunistring: Update to 1.3

    Committers note:
    Add a few more sections in port Makefile to make it easier to follow and
    to follow Porters Handbook more closely

    Changelog: https://savannah.gnu.org/news/?id=10682

    PR:             283588

 devel/libunistring/Makefile                              |  7 ++++---
 devel/libunistring/distinfo                              |  6 +++---
 .../files/patch-lib_unistr_u8-strncpy.c (new)            | 16 ++++++++++++++++
 devel/libunistring/pkg-plist                             |  3 +--
 4 files changed, 24 insertions(+), 8 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2025-01-15 19:49:22 UTC
Committed, thanks!