Bug 283939 - bsdinstall: Show error message on firmware menu
Summary: bsdinstall: Show error message on firmware menu
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 14.2-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-08 20:27 UTC by Renato Botelho
Modified: 2025-01-22 21:32 UTC (History)
3 users (show)

See Also:
garga: mfc-stable14+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer freebsd_triage 2025-01-08 20:27:48 UTC 
I was installing FreeBSD 14.2-RELEASE on a Thinkpad X230 and when installer reached "FreeBSD Firmware Installation" screen it showed the error message "No package found for device 0x0166" wrongly inside menu items as you can see at

https://imgur.com/a/mrVNxwb
Comment 1 Renato Botelho freebsd_committer freebsd_triage 2025-01-08 20:44:38 UTC 
fwget prints that message to stdout even with -q so it's mostly an fwget problem
Comment 2 Alexander Ziaee freebsd_committer freebsd_triage 2025-01-09 04:28:29 UTC 
^triage: We've seen a lot of people posting screenshots about this in the community discord as well
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2025-01-09 12:22:12 UTC 
I've proposed a fix for fwget

https://reviews.freebsd.org/D48391
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-09 14:23:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=19a6bc9f51e5c5705a2b396b0da61e6536acb4cb

commit 19a6bc9f51e5c5705a2b396b0da61e6536acb4cb
Author:     Renato Botelho <garga@FreeBSD.org>
AuthorDate: 2025-01-09 12:16:10 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2025-01-09 14:21:11 +0000

    fwget: Silence log() when -q is used

    Summary:
    Silence log function when -q parameter is used to prevent undesired output

    PR:             283939
    Reviewed By:    manu
    Differential Revision:  https://reviews.freebsd.org/D48391
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 usr.sbin/fwget/fwget.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 5 Renato Botelho freebsd_committer freebsd_triage 2025-01-09 14:27:43 UTC 
I'm not used to commit on src so I forgot to add the MFC to commit log but we certainly should MFC it to stable/14
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-01-22 21:29:10 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e6061e54d6d4c0549b259c7d94630a6511561007

commit e6061e54d6d4c0549b259c7d94630a6511561007
Author:     Renato Botelho <garga@FreeBSD.org>
AuthorDate: 2025-01-09 12:16:10 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2025-01-22 21:28:44 +0000

    fwget: Silence log() when -q is used

    Summary:
    Silence log function when -q parameter is used to prevent undesired output

    PR:             283939
    Reviewed By:    manu
    Differential Revision:  https://reviews.freebsd.org/D48391
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit 19a6bc9f51e5c5705a2b396b0da61e6536acb4cb)

 usr.sbin/fwget/fwget.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)