Bug 283968 - net/wireshark: multiple "silent grabs" even in poudriere
Summary: net/wireshark: multiple "silent grabs" even in poudriere
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-09 22:58 UTC by Vladimir Druzenko
Modified: 2025-01-12 20:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-09 22:58:42 UTC
1. In poudriere:
Error: /usr/local/lib/libwsutil.so.16.0.0 is linked to /usr/local/lib/libpcre2-8.so.0 from devel/pcre2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libpcre2-8.so:devel/pcre2

2. On live system it find minizip-ng and zlib-ng and can't link with -lminizip-ng.

3. Errors from make stage-qa on live system:
Warning: you may not need USES=ssl
Error: /usr/local/bin/dumpcap is linked to /usr/local/lib/libpcap.so.1 from net/libpcap but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libpcap.so:net/libpcap
Error: /usr/local/bin/dumpcap is linked to /usr/local/lib/libpcre2-8.so.0 from devel/pcre2 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libpcre2-8.so:devel/pcre2
Error: /usr/local/lib/wireshark/plugins/4.4/codecs/amrnb.so is linked to /usr/local/lib/libopencore-amrnb.so.0 from audio/opencore-amr but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libopencore-amrnb.so:audio/opencore-amr
Warning: you might not need LIB_DEPENDS on libgpg-error.so
Warning: you might not need LIB_DEPENDS on libintl.so
Warning: you might not need LIB_DEPENDS on libintl.so
Warning: you might not need LIB_DEPENDS on libQt6Svg.so
Warning: Possible REINPLACE_CMD issues:
- - REINPLACE_CMD ran, but did not modify file contents: cmake/modules/FindLua.cmake
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/wireshark/plugins/4.4/codecs/amrnb.so
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

4. Build in poudriere print same warnings as in 3:
Warning: you might not need LIB_DEPENDS on libgpg-error.so
Warning: you might not need LIB_DEPENDS on libintl.so
Warning: you might not need LIB_DEPENDS on libintl.so
Warning: you might not need LIB_DEPENDS on libQt6Svg.so

5. CMakeOptions.txt have lines:
option(ENABLE_PCAP       "Enable libpcap support (required for capturing)" ON)
option(ENABLE_ZLIB       "Build with zlib compression support" ON)
option(ENABLE_ZLIBNG     "Build with zlib-ng compression support" ON)
option(ENABLE_MINIZIP    "Build with zip file compression support" ON)
option(ENABLE_MINIZIPNG  "Build with zip file compression support" ON)
option(ENABLE_LZ4        "Build with LZ4 compression support" ON)
option(ENABLE_BROTLI     "Build with brotli compression support" ON)
option(ENABLE_SNAPPY     "Build with Snappy compression support" ON)
option(ENABLE_ZSTD       "Build with Facebook zstd compression support" ON)
option(ENABLE_NGHTTP2    "Build with HTTP/2 header decompression support" ON)
option(ENABLE_NGHTTP3    "Build with HTTP/3 header decompression support" ON)
option(ENABLE_LUA        "Build with Lua dissector support" ON)
option(ENABLE_SMI        "Build with libsmi snmp support" ON)
option(ENABLE_GNUTLS     "Build with RSA decryption support" ON)
option(ENABLE_KERBEROS   "Build with Kerberos support" ON)
option(ENABLE_SBC        "Build with SBC Codec support in RTP Player" ON)
option(ENABLE_SPANDSP    "Build with G.722/G.726 codecs support in RTP Player" ON)
option(ENABLE_BCG729     "Build with G.729 codec support in RTP Player" ON)
option(ENABLE_AMRNB      "Build with AMRNB codec support in RTP Player" ON)
option(ENABLE_ILBC       "Build with iLBC codec support in RTP Player" ON)
option(ENABLE_LIBXML2    "Build with libxml2 support" ON)
option(ENABLE_OPUS       "Build with opus support" ON)
option(ENABLE_SINSP      "Build with libsinsp+libscap support" ON)

If we don't want to use libs from list we must add records to CMAKE_OFF in Makefile.
For example "CMAKE_OFF+=ENABLE_AMRNB ENABLE_MINIZIPNG ENABLE_ZLIBNG" prevent error from 2 and 3.
Or we can add options to port.

Fix warnings from 3 and 4 (and error from 1):
-LIB_DEPENDS=    libgpg-error.so:security/libgpg-error \
+LIB_DEPENDS=    libpcre2-8.so:devel/pcre2 \

-USES=           cmake compiler:c++11-lang cpe gettext-runtime gnome \
+USES=           cmake compiler:c++11-lang cpe gettext-runtime:build gnome \

-GUI_USE=                qt=5compat,base,multimedia,svg,tools
+GUI_USE=                qt=5compat,base,multimedia,tools

Don't know how to force use system libpcap if net/libpcap installed from ports.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2025-01-10 13:53:47 UTC
Thanks for this!  It has been a while since I did the cmake diving.  I'll poke at this over the weekend.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-01-12 20:23:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=13f111ae0359b476c0028709316aab0d97430c29

commit 13f111ae0359b476c0028709316aab0d97430c29
Author:     Joe Marcus Clarke <marcus@FreeBSD.org>
AuthorDate: 2025-01-12 20:20:33 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2025-01-12 20:20:33 +0000

    net/wireshark: Refine dependencies

    Remove unneeded dependencies, turn off some cmake options, and add a
    dependency on libnghttp3.

    PR:             283968
    Submitted by:   vvd (based on)

 net/wireshark/Makefile | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2025-01-12 20:23:24 UTC
Fixed in 4.4.3_1.  Thanks!